phase shift from isolator effects loaded in regular effect unit creates comb filtering
Bug #1740521 reported by
Be
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
New
|
Undecided
|
Unassigned | ||
Bug Description
1. Load Bessel4 ISO, Bessel8 ISO, BQ EQ/ISO, or LR8 ISO effects in regular effect unit.
2. Set mix knob of unit to half (1/2 dry, 1/2 wet)
3. Turn on effect
This creates a strange sounding comb filtering. This does not occur with the equalizer effects based on biquad filters (BQ EQ, Graphic EQ, Param EQ). How should we handle this? Should we hide the isolator effects from the regular effect units? I think the biquad EQ effects cover all use cases. There may be some fancy phase compensation algorithm we could implement, but I do not know if that is worth the code complexity or CPU cost.
Revision history for this message
| Daniel Schürmann (daschuer) wrote | #1 |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #2 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
This effects all effect with a group delay.
Basically all fidlib based filter suffer this problem. The biquad based EQs are also effected when not at unity.
We may add a group delay reporting facility and compensate the dry pass accordingly but unfortunately the group delay is also frequency depending for all non Bessel EQs
So we need a kind off all pass filter for compensation.