Repeated import of cover art from files

[Uwe Klotz]

Cover art for the same track might be requested from UI components like widgets in the library, the cover art display on the deck and the spinnies almost concurrently. The cover art cache accepts multiple requests for the same track from different requestores if the cover is not cached already, although all requests reference the same file. Why? Because the requestId contains both the requestor and the cover hash.

As a consequence multiple subsequent read operations for the same cover art image are performed. For embedded cover art this becomes obvious from the logs, because a SoundSourceProxy is created and embedded cover art is parsed repeatedly from the audio file, e.g. when loading a track into a deck.

Pending requests for the same cover hash need to be combined instead of creating new requests.

[Uwe Klotz (uklotzde-deactivatedaccount)]

Should IMHO be fixed before releasing 2.1.0.

[Daniel Schürmann (daschuer)]

The rejected PR for the cover hash might be related.
https://github.com/mixxxdj/mixxx/pull/996

[Uwe Klotz (uklotzde-deactivatedaccount)]

Both issues are unrelated, although targeting overlapping parts of the code.

[Uwe Klotz (uklotzde-deactivatedaccount)]

I won't be able to complete this in time. It turned out that the caching and hashing needs to be changed to implement this properly. Maybe has more dependencies with https://github.com/mixxxdj/mixxx/pull/996 than expected.

[Be (be.ing)]

Uwe or Daniel, would one of you like to assign yourself to take this up for 2.2?

[RJ Skerry-Ryan (rryan)]

Due to lack of progress, marking Triaged and clearing assignee. Feel
free to revert if it is in fact still in progress :).

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8991