Mixxx

skin text is not translatable

Bug #1731653 reported by Be on 2017-11-11

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	Mixxx	Confirmed	High	Unassigned

Bug Description

We now have lots of text labels in skins. These need to use translatable strings. The WPushButton and WLabel widgets need to be modified to handle this.

Be (be.ing) on 2017-11-11

Changed in mixxx:
importance:	Undecided → High
milestone:	none → 2.1.0

Revision history for this message

ronso0 (ronso0) wrote on 2017-11-11:

I partly agree this is a bug:
Yes: for the skin settings menus in Deere and Tango
No: most buttons in skin itself
I don't agree it's high priority.

If we make labels like "head gain" translatable, i.e. the french translation will never fit the button and therefor require eliding (right? center?) which will look messy IMO

One reason for me to prefer icons over text in Tango was that they are multilingual (maybe even multicultural since DJs across the globe share international equipment) and they require less space in 99,9%.
Take a look at Tango's HeadSplit buttons for example. Can't we come up with equally distinct icons for other buttons/knobs as well instead of implementing the translation engine for buttons and also fix all skins for 2.1?

Revision history for this message

Be (be.ing) wrote on 2017-11-11:

I agree that buttons are preferable to text outside of the skin settings menu. Graphic design is not one of my strengths, but if you'd like to make icons to replace text in Deere, that would be welcome.

Be (be.ing) on 2017-11-12

Changed in mixxx:
importance:	High → Medium

Revision history for this message

Be (be.ing) wrote on 2017-11-12:

Moving this back to High priority because it has to be fixed before string freeze.

Changed in mixxx:
importance:	Medium → High

Revision history for this message

Be (be.ing) wrote on 2017-12-11:

I'm not sure it is feasible to implement this and finish everything else before the 2.1 beta release. Is using icons where possible good enough for 2.1? That should leave most text in skins in the skin settings menus.

Be (be.ing) on 2017-12-18

Changed in mixxx:
milestone:	2.1.0 → none

Be (be.ing) on 2017-12-28

Changed in mixxx:
milestone:	none → 2.2.0
status:	New → Fix Committed
status:	Fix Committed → Confirmed

Be (be.ing) on 2018-06-24

Changed in mixxx:
milestone:	2.2.0 → 2.3.0

Be (be.ing) on 2019-09-14

Changed in mixxx:
milestone:	2.3.0 → none

Revision history for this message

ronso0 (ronso0) wrote on 2019-12-09:

When we agree this affects the skin settiings menu only, a separate skin settings widget would solve the issue for me.

"Move Skin menu to a pop up / slide over menu"
https://bugs.launchpad.net/mixxx/+bug/1765926

Revision history for this message

Be (be.ing) wrote on 2019-12-09:

There is more text in the skins than just the skin settings menus. So that wouldn't fully solve the problem.

Revision history for this message

ronso0 (ronso0) wrote on 2019-12-09:

I'm not sure what you refer to:
* tooltips are translatable
* Libary feature buttons are translatable
* compact button labels like MIXER, AUX, BROADCAST, VINYL can be considered 'global' IMO, also translations would screw up skin layouts

What else did I miss?

Revision history for this message

Swiftb0y (swiftb0y) wrote on 2022-10-08:

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8965