effect specific Meta knob/QuickEffect knob default position

[ronso0]

Right-clicking Meta and QuickEffect knobs resets it to zero (fully left).
For most effects (with default paramter links) this also resets the whole effect to "no effect", but for example with Filter it deosn't work because the Meta knob drags the low-pass filter to zero as well = no sound.

It would facilitate the effects workflow if there's an effect-specific default position which has "no effect" on assigned channels, as long as Meta links are still default.

Also, it would help if the notch of the Meta knob's ring would indicate that default position.

Related PR KnobComposed masked ring https://github.com/mixxxdj/mixxx/pull/645

[ronso0 (ronso0)]

..whereas the QuickEffect knob is centered by default, but that's useful only for filters.
Also, filter knob is not saved to effects.xml, unlike knobs in effect units.

[Ferran Pujol (ferranpujol)]

What about superknob? Any ideas?

[ronso0 (ronso0)]

Saving or resetting?
Resetting it should IMO result in "no effect" as well.

[Ferran Pujol (ferranpujol)]

But where is "no effect" for the super knob? It depends on what parameters are linked and the link type. How do we determine the "no effect" position?
Morover, by setting appropriate link types, the superknob can be setup to transform sound in any knob position. So superknob doesn't always have a "no effect" position.

Should we let the user configure the reset position of the superknob?

[ronso0 (ronso0)]

Sry, referred to Meta knob. I updated the description to be more precise.
Of course, as soon as a user changes the Meta links, he can't expect any defaults anymore. But with default parameter links we could define such a "no effect" position: center for Balance and filters, and fully left for most (all?) other effects.

[Ferran Pujol (ferranpujol)]

As discussed here: https://github.com/mixxxdj/mixxx/pull/1517

The followingsolution was proposed

I think the user should have a preference option called "set default effect parameters on effect load".

If "set default effect parameters on effect load" is set to false:

    When a new effect is loaded all parameters including the metaknob remain at the current position

If "set default effect parameters on effect load" is set to true:

    All effect knobs are set to their default position. The meta knob is also set to a default position that is defined by each effect.

[Be (be.ing)]

https://github.com/mixxxdj/mixxx/pull/1574

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8882