replace deprecated QGLWidget with QML

Bug #1687937 reported by Tatsuyuki Ishi
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
In Progress
High
Unassigned

Bug Description

As a part of Qt5 port, GL-based waveform renderers alongside with other things that use raw GL should be ported to the new API, QOpenGLWidget.

Some notes:
- The renderer GL code should be rewritten. They're in the deprecated GL API (glBegin, glEnd, glOrtho, ...) which should be replaced with modern OpenGL (see open.gl for some description).
- Either drop Qt4 or pollute the code with tons of preprocessor version checks.
- The OpenGL context can be shared without a helper class
- There's no guarantee that the OpenGL context is created upon construction, so such detection method is likely not to work

Tags: waveform
Revision history for this message
Be (be.ing) wrote :

Perhaps related: Bug #1718066

Changed in mixxx:
milestone: none → 2.2.0
RJ Skerry-Ryan (rryan)
Changed in mixxx:
importance: Undecided → Wishlist
status: New → Confirmed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: 2.2.0 → 2.3.0
Revision history for this message
Be (be.ing) wrote :
Changed in mixxx:
importance: Wishlist → Critical
milestone: 2.3.0 → 2.2.0
status: Confirmed → In Progress
summary: - Waveforms and other widgets should be ported to QOpenGLWidget
+ replace deprecated QGLWidget with QOpenGLWidget
Revision history for this message
Daniel Schürmann (daschuer) wrote : Re: replace deprecated QGLWidget with QOpenGLWidget

This bug dies not describe a critical issue.
The issue described here is the deprecated state. That is not critical.

In general we should not rush into this mayor change for 2.2 it is simply not enough time for testing this mayor change.
If we cannot fix the Mac is issue without this change I vote for a qt4 release which is scheduled 2018-11-17 in three weeks.

Changed in mixxx:
importance: Critical → Wishlist
milestone: 2.2.0 → none
Revision history for this message
Be (be.ing) wrote :

We have reports that Mixxx 2.2 is entirely unusable with macOS with QGLWidget, therefore this is critical: https://mixxx.zulipchat.com/#narrow/stream/109122-general/subject/MacOS.20rendering.20issue.20(possibly.20hiDPI.20related)/near/136167907

I'm not going to repeat myself why reverting to a library that hasn't been maintained in 7 years is not an acceptable solution.

Changed in mixxx:
milestone: none → 2.2.0
importance: Wishlist → Critical
Revision history for this message
Be (be.ing) wrote :

It seems this is related to building with the 10.14 macOS SDK. We are using the 10.13 macOS SDK on the build server for 2.2, so we may not need to rush this for 2.2.
https://bugreports.qt.io/browse/QTBUG-71292

Changed in mixxx:
milestone: 2.2.0 → 2.3.0
RJ Skerry-Ryan (rryan)
Changed in mixxx:
importance: Critical → Low
tags: added: deprecation
Be (be.ing)
Changed in mixxx:
milestone: 2.3.0 → 2.4.0
tags: added: waveform
removed: deprecation
Changed in mixxx:
importance: Low → High
Be (be.ing)
Changed in mixxx:
milestone: 2.4.0 → none
summary: - replace deprecated QGLWidget with QOpenGLWidget
+ replace deprecated QGLWidget with QML
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8853

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.