Segmentation fault on changing key to a very very low value

[Wihola IT]

I have made a midi mapping for an infinite rotary that can change a key. If making it lower and lower, at some point mixxx will crash.

[Be (be.ing)]

From the backtrace it looks like you are using SoundTouch. Does this also occur if you use Rubberband? You can switch between them in the Sound Hardware Preferences (that is admittedly a confusing place for that preference option).

[Wihola IT (wihola)]

Debug [Controller]: "__control: "
Debug [Controller]: "CMD PL-1 MIDI 1: outgoing: status 0xB0 (ch 1, opcode 0xB), ctrl 0x04, val 0x97"
Resampler::process: libsamplerate error: SRC ratio outside [1/256, 256] range.
terminate called after throwing an instance of 'RubberBand::Resampler::Exception'
Aborted

I understand that this is cheating, and I need to make a javascript function works the smart way. But I still can crash mixxx with a dumb way.

[Wihola IT (wihola)]

The same occurs if I will make the pitch higher and higher in the Rubberband mode.

[Daniel Schürmann (daschuer)]

I can confirm this, [Channel1],pitch = 30 works and [Channel1],pitch = 40 -> crash (Soundtouch)
Rubberband crashes later, at least at 300.
I think a good band aid is to limit these values to a reasonable number.

[Daniel Schürmann (daschuer)]

@Wihola IT: do you have fun to adopt this bug?

[Wihola IT (wihola)]

@daschuer, yes.

[Be (be.ing)]

Wihola IT, have you made any progress working on this bug or should someone else take it up for 2.1?

[Wihola IT (wihola)]

Hello Be. I am not going to make it.

On 11.11.17 18:13, Be wrote:
> Wihola IT, have you made any progress working on this bug or should
> someone else take it up for 2.1?
>

[Wihola IT (wihola)]

I am not able to make it.

[Be (be.ing)]

Considering this only affects an edge case and has only been reported by one user, I am demoting it from Critical to High. If someone wants to step up to take care of this for 2.1, reassign it to that milestone.

[Jan Holthuis (holthuis-jan)]

I can still reproduce this. If I set `[Channel1],pitch` or `[Channel1],pitch_adjust` to 100, it still works. If I set it to 200, mixxx is killed with `SIGKILL` automatically.

[Jan Holthuis (holthuis-jan)]

This should be rather easy to fix. Just clamp the value to a reasonable range, like -30 or 30, using the `connectValueChangeRequested` mechanism.

[ronso0 (ronso0)]

https://github.com/mixxxdj/mixxx/pull/4354

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8847