Effects are enabled without choosing a channel

[Daniel Schürmann]

This can happen when switching between Shade and Deere.

Shade uses the BusLeft and BusRight as Effect hooks.

Since the [EffectRack1_EffectUnit1],group_[BusLeft]_enable and friends are now persistent, it can happen that you have them enabled before you close it. If you switch to Deere, you have no chance to disable it again.

This can bes solved by adding all effect group enable buttons to all skins, or by switching all unused effect hooks off in the skin manifest.

[Be (be.ing)]

I think this should be solved by replacing the BusLeft/BusRight switches in Shade with Channel1/Channel2.

[Be (be.ing)]

Shade needs to conform with other skins to support controller mappings.

[Daniel Schürmann (daschuer)]

> I think this should be solved by replacing the BusLeft/BusRight switches in Shade with Channel1/Channel2.

If we do not remove the BusLeft/BusRight switches this would be only a short coming band-aid.

The BusLeft/BusRight/BudMid effect hooks where introduced, to have a low CPU option to put an effect to anything that is passed to the mixer.
It allows for example to put effects on any of the N-Samplers.

I think it is worth to keep them.

[Be (be.ing)]

I don't think the possibility to assign EffectUnits to BusLeft/BusRight/BusMid should be removed from the engine, but I don't think they should be shown in skins. It's not obvious that those buttons in Shade affect the BusLeft/BusRight channels instead of the decks. So, it's not clear that the samplers could be routed through effects by assigning them to a side of the crossfader and pressing one of those BusLeft/BusRight buttons.

Couldn't samplers still be used with external mixers if they were assigned to a side of the crossfader and routed to an effect unit? I think it would be more intuitive to put buttons in the samplers to assign them to an effect unit (putting all those buttons in the effect units would require a lot of space in the effect units regardless of whether the user is using samplers).

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8803