[Playlist],SelectPlaylist doesn't work anymore

[ronso0]

When a playlist, crate or other view has focus, the following controls for side pane don't work, unless library side pane is focused manually:

[Playlist],SelectNextPlaylist
[Playlist],SelectPrevPlaylist
[Playlist],SelectPlaylist
Probably other [Playlist] controls are affected as well.

On the other hand, when side pane has focus Track controls still work in track table:
[Playlist],SelectNextTrack
[Playlist],SelectPrevTrack
[Playlist],SelectTrackKnob

It was working until I recently switched from r6071 to r6109.

[Be (be.ing)]

Update your mapping for the new [Library] COs:
http://mixxx.org/wiki/doku.php/mixxxcontrols#library

introduced by https://github.com/mixxxdj/mixxx/pull/953

[RJ Skerry-Ryan (rryan)]

This means we broke backwards compatibility, so it's still a bug though.

[ronso0 (ronso0)]

Thank, that's a ton of new controls! nice.

This also means controller presets can be updated/reworked..

Is there a changelog somewhere? It's hard to track changed controls, new sin features, etc. so it would be very helpful to have one.

[Be (be.ing)]

You can look at the changelog of the mixxxcontrols wiki page:
http://mixxx.org/wiki/doku.php/mixxxcontrols?do=revisions

The changes should be summarized on the new upgrading mappings page:
http://mixxx.org/wiki/doku.php/updating_controller_mappings

[Tim (timrae)]

Thanks for the report, it looks like it was only those controls that were affected. PR submitted:
https://github.com/mixxxdj/mixxx/pull/1137

[ronso0 (ronso0)]

@timrae Thanks for fixing. Though I already switched to the new COs in the meantime..
@be.ing Thanks for pointing me there. Going through the revisions would not be very obvious/easy for users switching to 2.1 alpha while controller presets are not updated, yet. http://mixxx.org/wiki/doku.php/updating_controller_mappings is handy altough the COs in question are not listed yet.

[Tim (timrae)]

@ronso0

Currently the best place to look for changes is the list of deprecated
controls:
http://www.mixxx.org/wiki/doku.php/mixxxcontrols#deprecated_controls

On Tue, Jan 24, 2017 at 1:06 AM, ronso0 <email address hidden> wrote:

> @timrae Thanks for fixing. Though I already switched to the new COs in the
> meantime..
> @be.ing Thanks for pointing me there. Going through the revisions would
> not be very obvious/easy for users switching to 2.1 alpha while controller
> presets are not updated, yet. http://mixxx.org/wiki/doku.
> php/updating_controller_mappings is handy altough the COs in question are
> not listed yet.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1657743
>
> Title:
> [Playlist],SelectPlaylist doesn't work anymore
>
> Status in Mixxx:
> Fix Committed
>
> Bug description:
> When a playlist, crate or other view has focus, the following controls
> for side pane don't work, unless library side pane is focused
> manually:
>
> [Playlist],SelectNextPlaylist
> [Playlist],SelectPrevPlaylist
> [Playlist],SelectPlaylist
> Probably other [Playlist] controls are affected as well.
>
> On the other hand, when side pane has focus Track controls still work in
> track table:
> [Playlist],SelectNextTrack
> [Playlist],SelectPrevTrack
> [Playlist],SelectTrackKnob
>
>
> It was working until I recently switched from r6071 to r6109.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1657743/+subscriptions
>

[ronso0 (ronso0)]

Thanks again.

I really hope I'm not annoying here, when I propose another feature:
To extend the use of the new as well as the old COs, it would be very cool to have a 'feedback' CO like TreeViewHasFocus, TrackTableHasFocus, TreeItemIsCollapsed (or whatever is coming with the Library redesign in progress).

I currently use the new COs (especially fast scrolling is handy for long playlists/history), but I also sometimes use the mouse for overview waveform or whatever. After doing so, neither Tree nor Tracks have focus. A while after that -hands on the controller- I want to select and load a track from Tracks table, but would have to put focus back there manually.
I think, with the proposed COs it would be easy to create script solutions for various scenarios/flavours and for many different controller layouts.

[Daniel Schürmann (daschuer)]

Since this bug is fixed, please copy your request to a new bug.
Than we can track it separate.

For me it sounds more like a bug, and that should not bother the controller.
Does it also happen in the new library redesign branch?

[ronso0 (ronso0)]

Sorry for the delay.

I will test again as soon as the redesign is merged.

[ronso0 (ronso0)]

I reported that focus loss in https://bugs.launchpad.net/mixxx/+bug/1673196

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8766