new CO "num_all_parameters" to sum up button & knob parameters

Bug #1656626 reported by ronso0
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
New
Wishlist
Unassigned

Bug Description

Have a CO like [...EffectM],num_total_parameters to have the total of all button and knob parameters loaded by [EffectM]. Actually the sum of already available COs [...],num_parameters and [...],num_button_parameters

I expect this to come in handy for skinning the FX unit slots using placeholders.

Tags: effects
Revision history for this message
Be (be.ing) wrote :

I don't understand what value this would add. Can you elaborate on why it would be useful?

Revision history for this message
ronso0 (ronso0) wrote : Re: [Bug 1656626] Re: new CO "num_all_parameters" to sum up button & knob parameters

I'll take a screenshot for explanation.

As I said it's just a wish, luxury. I looked at the code and think I can
implement it myself.

Revision history for this message
ronso0 (ronso0) wrote :

Please, have a look at this screenshot
http://ibb.co/h8U2aa

The CO would allow displaying placeholders whose width depends on the overall number of parameters, so that the first parameters of effects are aligned, no matter how many knobs/buttons respective effect has. I'd like to have them aligned because it helps relating their position in skin and on the controller. This would apply to all effects with up to 4 parameters, above that (8-band EQ, Phaser) the parameter row would expand to the left.
The whole effect slot, however, should be aligned to the right (center of the skin) to keep all important UX elements closer together.

I didn't find a way to do this qproperty-layoutAlignment and min-width: it became complex and something would always break, alignment or width.

(writing this took longer than creating the CO, I guess)

Revision history for this message
Be (be.ing) wrote :

Can't you use a MinimumExpanding spacer to push them to the right?

Revision history for this message
Be (be.ing) wrote :

Nevermind the above comment; I misunderstood.

I think the way you are trying to align the parameters is confusing. If you shift the BitCrusher parameters as described in the image, then the graphic EQ parameters will be misaligned. It will look like controller knobs should control the 1.1 kHz and up parameters of the graphic EQ, but those are not actually the first 3 parameters of the graphic EQ.

Revision history for this message
ronso0 (ronso0) wrote :

Yes, I see what confuses you. But on the other hand, users might expect (and accept) that there's no reasonable way to control an 8-parameter effect with 3 knobs.

I must state that I really got used to the alignment described above, it's an intuitive connection when glancing at physical knobs and checking parameters on screen.

Despite the inconsistency for more than 5 parameters (buttons & knobs) I still think this CO might be valuable (admittedly, for THIS skin with THIS kind of alignment). I can imagine to put some kind of subtle visual higlight on those first three parameters linked to physical knobs, and offer this option to the user in skin settings.

Revision history for this message
ronso0 (ronso0) wrote :

I don't need this feature anymore for the skin, just aligned them normally.
But I still think this could be useful to react on the number of parameters.

Changed in mixxx:
importance: Undecided → Wishlist
tags: added: effects
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8762

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.