Controller presets should be listed alpahbetically in drop-down menu

Bug #1649724 reported by ronso0
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Undecided
Nimit Bhardwaj

Bug Description

Title says it all.
Furthermore some presets appear to be in alphabetical order. One wouldn't go back to the top looking for 'Txxxx' after sorted presets for 'Rxxxx' and 'Sxxxxx'. This might drive impatient/superficial users away when trying this nice FOSS dj software.

Noticed this when looking for my updated preset for Reloop which showed up near the top.

2.1-aplha-pre
linux64

Revision history for this message
Sébastien BLAISOT (sblaisot) wrote :

Can you reproduce this with a fresh profile ?
mixxx --settingsPath /tmp/mixxx-profile

AFAIK mappings from you user preference directory show first (alphabetically sorted), then mappings from the system-wide mixxx folder all appears alphabetically sorted.

This could explain why you see your own mapping first or near the top after having using it once. It always show first the mapping you have already used.

Revision history for this message
ronso0 (ronso0) wrote :

This is what I did, actually. Built r6024 and ran it from build dir with
./mixxx --resourcePath res/ --settingsPath .mixxx/
I removed .mixxx/controllers prior to every test and the changed preset always showed up near top.

Just tried it with 2.1-alpha-pre from the repo and clean/no profile.
Entries are in this order
Kontrol DJblaa
DJTech DJM-01
Gemini CMDP
Vestax
Pioneer
...

Revision history for this message
Be (be.ing) wrote :

I have noticed this lately too. It did not used to happen. Not sure what changed in the meantime.

Changed in mixxx:
status: New → Confirmed
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Without using a Controller you can whatch the bug by starting Mixxx with
mixxx --developer

Options->Preferences->Controllers->Expand Tree->Midi Though Port-0

The Combobox with the issue is "Load Preset:"
https://github.com/mixxxdj/mixxx/blob/8d191bf7ce2d62d24c6e0ffac4b2afd7359afa8a/src/controllers/dlgprefcontrollerdlg.ui

tags: added: easy
Revision history for this message
Nimit Bhardwaj (nimitbhardwaj) wrote :

I found the position where the presets are added in the combo box, this is at src/controllers/dlgprefcontroller.cpp at line 241, where the void DlgPrefController::enumeratePresets() starts, in this function the addition of the presets to the combo box takes place, so here only left task is to sort the presets in the Lexicographical order, which I can do with the function sort of the standard template library

Or any other function I use which have better time complexity than Nlog(N), (may be not present such function yet), yes especially for this length of data please tell

Changed in mixxx:
assignee: nobody → Nimit Bhardwaj (nimitbhardwaj)
Revision history for this message
Nimit Bhardwaj (nimitbhardwaj) wrote :
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Confirmed → Fix Committed
milestone: none → 2.1.0
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8720

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.