Allow to load a track via keyboard

[Daniel Schürmann]

"Enter" is the most natural key for that, the compliment for double click with the same functionality.

[Daniel Schürmann (daschuer)]

https://github.com/daschuer/mixxx/commits/libraryFocus

[jus (jus)]

Whats wrong with the
Shift + left
Shift + right

combo we have for years?

> On Oct 8, 2016, at 15:13, Daniel Schürmann <email address hidden> wrote:
>
> Public bug reported:
>
> "Enter" is the most natural key for that, the compliment for double
> click with the same functionality.
>
> ** Affects: mixxx
> Importance: Wishlist
> Assignee: Daniel Schürmann (daschuer)
> Status: In Progress
>
> ** Changed in: mixxx
> Status: New => In Progress
>
> ** Changed in: mixxx
> Importance: Undecided => Wishlist
>
> ** Changed in: mixxx
> Assignee: (unassigned) => Daniel Schürmann (daschuer)
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1631602
>
> Title:
> Allow to load a track via keyboard
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1631602/+subscriptions

[Daniel Schürmann (daschuer)]

There is nothing wrong with that in the first place, but that does not work for Deck 3 and 4 and does not match the double click action that can be configured in the preferences to be either load to Auto DJ or load to a free deck.

I am currently working to make the new N-Pane library controllable via keyboard.
The first step is to make the "normal" keyboard control used in most other desktop apps work again. Change widget by Tab, Enable by Enter, and so on. "Enter" always matches the click or double click action, IMHO that should work like that in Mixxx as well.

I am considering to do it an mandatory way that the keys are processed first by the static widget key processing code. Only unused keys are passed to the keyboard mappings.
This model is already used for the search box and other similar library widgets.

This allows to reuse some keys for every widget e.g. "Enter" on the button bar will "click" the button, "Enter" on a playlist will show the playlist and "Enter" on a Track will load it.

Later these functions should be accessible by midi mappings as [Library],"Enter" as well.

Note, if we do it like that, we cannot map the "Enter" key bay a keyboard mapping any more.
That should be IMHO no issue in the first place. If we later recognize that there is a need for it, we may allow to map Keys on the Application level, which are processed first.
Here are the effected keys in the track table case: https://github.com/daschuer/mixxx/commit/93f09876e3142d79caa4beebc3266b5aa624a737#diff-61349d31f213f893363ef94336c26f62R1296

What do you think?

By the way, I have also disabled the in-table track title edit, that was hard to use anyway and conflicts with the enter key.

[RJ Skerry-Ryan (rryan)]

Due to lack of progress, marking Triaged and clearing assignee. Feel
free to revert if it is in fact still in progress :).

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8661