TagLibTest.WriteID3v2Tag test fails under windows

[Sébastien BLAISOT]

[----------] 1 test from TagLibTest
[ RUN ] TagLibTest.WriteID3v2Tag
src\test\taglibtest.cpp(37): error: Value of: QFile::remove(tmpFileName)
  Actual: false
Expected: true
[ FAILED ] TagLibTest.WriteID3v2Tag (1 ms)
[----------] 1 test from TagLibTest (1 ms total)

[Uwe Klotz (uklotzde-deactivatedaccount)]

Which version of Qt did you use?

The failed assertion simply checks that the temporary file has actually been removed before reusing its generated file name for copying an existing file over it. You can safely remove this assertion and run the test again.

[Uwe Klotz (uklotzde-deactivatedaccount)]

Btw, I'm looking for updated instructions on how to easily set up a Windows build environment ;) The instructions in the Wiki never worked out of the box and I don't have time to figure this out.

[Sébastien BLAISOT (sblaisot)]

I'm using QT 4.8.7

If you Want, I can put somewhere my prebuilt Windows build env. This way , you only have to download and extract it plus install the build tools (msvs, python, nsis,...)

[Sébastien BLAISOT (sblaisot)]

I suspect open() creates a file under linux, but only creates the file under windows when effectively writing into it.

I don't understand why exists() returns true, even if you move it after close().

[Uwe Klotz (uklotzde-deactivatedaccount)]

If you are able to upload your working Windows build environment somewhere that would be great :) I need only the compiled 3rd-party components and maybe some hints about the required directory structure.

Are we still using VS2013?

[Sébastien BLAISOT (sblaisot)]

yes, I'm using VS2013, this was the recommended compiler at the time I built my mixxx-2.0 build env ;)
I wait for Pegasus to finish his work on the mixxx-2.1 build env to switch to VS2015, QT5 and updated build env.

I'll upload my prebuilt windows build env for you this afternoon.

[Sébastien BLAISOT (sblaisot)]

Why don't you directly use your QTemporaryFile object in your test and create a second QFile copiedFile object ?
As far as I understand, QTemporaryFile inherits all methods of QFile.

[Uwe Klotz (uklotzde-deactivatedaccount)]

As far as I can remember this workaround was necessary to obtain a generated, unique file name for a temporary file. Maybe we can find a better way to achieve this.

[Sébastien BLAISOT (sblaisot)]

https://github.com/mixxxdj/mixxx/pull/1020

[Sébastien BLAISOT (sblaisot)]

@uwe : https://www.blaisot.org/mixxx-buildserver-windows/

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8657