osx opus crash
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Critical
|
RJ Skerry-Ryan |
Bug Description
reported on IRC. A faulty .opus file crashes 2.0.0. The file fails to load gracefully in master.
* thread #26: tid = 0x3bbca8, 0x0000000102e124d0 libopusfile.
frame #0: 0x0000000102e124d0 libopusfile.
libopusfile.
-> 0x102e124d0 <+16>: cmpl $0x2, 0x78(%rbx)
0x102e124d4 <+20>: jl 0x102e12510 ; <+80>
0x102e124d6 <+22>: cmpl $0x0, 0x28(%rbx)
0x102e124da <+26>: je 0x102e12510 ; <+80>
(lldb) bt
* thread #26: tid = 0x3bbca8, 0x0000000102e124d0 libopusfile.
* frame #0: 0x0000000102e124d0 libopusfile.
frame #1: 0x000000010059a817 mixxx`SoundSour
frame #2: 0x00000001005b8c66 mixxx`TrackInfo
frame #3: 0x00000001005b6c9d mixxx`TrackInfo
frame #4: 0x00000001005b65e9 mixxx`TrackInfo
frame #5: 0x00000001003bb10c mixxx`BrowseThr
frame #6: 0x00000001003bae15 mixxx`BrowseThr
frame #7: 0x0000000100e82a62 QtCore`
frame #8: 0x00007fff8ec1ec13 libsystem_
frame #9: 0x00007fff8ec1eb90 libsystem_
frame #10: 0x00007fff8ec1c375 libsystem_
Changed in mixxx: | |
milestone: | 2.0.1 → 2.1.0 |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
Looks like a simple lack of check for NULL returned from op_open_file.