analyze pane not respect custom row height

Bug #1535405 reported by Hendrik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Invalid
Low
Unassigned

Bug Description

The custom row height I've chosen in the preference pane is not reflected in the Analyze view.

Tags: library polish
Revision history for this message
Daniel Schürmann (daschuer) wrote :

On which OS are you?
I cannot confirm this on Ubuntu Trusty using Mixxx 2.0

Revision history for this message
Hendrik (index82) wrote :

Hi Daniel,

I use the same OS with latest Mixxx 2.1-alpha-pre (build r5590) self-compiled.
Additionally, the same behavior with Mixxx 2.0.0 (build 1:12 r 5772) via deb package on another clean machine with Trusty.

In the mixxx preference pane on both machines are these settings:
row height: 20 px
font face/height: Ubuntu 11 pt

The default values, I think.

On the analyze pane the measured row height is constant 30 px.

BTW. Custom font settings are also ignored on the analyze pane.
Reported here https://bugs.launchpad.net/mixxx/+bug/1427368

This file (for example) shows me some code
https://github.com/mixxxdj/mixxx/blob/master/src/dlghidden.cpp

void DlgHidden::setTrackTableFont(const QFont& font) {
    m_pTrackTableView->setTrackTableFont(font);
}

void DlgHidden::setTrackTableRowHeight(int rowHeight) {
    m_pTrackTableView->setTrackTableRowHeight(rowHeight);
}

But i don't find these snippets in
https://github.com/mixxxdj/mixxx/blob/master/src/dlganalysis.cpp

I hope it helps.

Kind regards!

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Oh sorry, I have actually increased the row high to 30 px from 20 px and then looked at the analysis view.
Now I can confirm.

Now that you are so close to a solution, do you have fun to adopt this bug and fix it yourself?
Here are some hints http://www.mixxx.org/wiki/doku.php/bugfix_workflow

Thank you very much.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Hendrik (index82) wrote :

I have no skills in C++, but I'll try to fix it.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Cool! If you have any questions, just ask.

Revision history for this message
ronso0 (ronso0) wrote :

Not reproducible anymore with 2.3

Changed in mixxx:
status: Confirmed → Invalid
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8448

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.