Add widget that displays the duration of a mix being recorded so far

[ronso0]

It would be nice to have an small indicator (like clock widget) which displays how long the mix is I'm currently recording.

My scenario: I do mixes for friends which should fit on a 70/80min audio CD, so it would be nice to
1) see duration of recording so far (to exhaust that 80 minutes)
2) have a pushbutton like "Start recording"

[Daniel Schürmann (daschuer)]

This is an ideal starter bug and to learn the Mixxx control system.
@ Ronny, do you have fun and time to dive into the Mixxx source?
If yes, I can give you some additional hints.

[ronso0 (ronso0)]

@Daniel: yes, I could do so. I'm back to this bug https://bugs.launchpad.net/mixxx/+bug/1462350 from this summer and for the PR I'm learning about git right now. If you think is good for a starter, go ahead with your hints...

[Daniel Schürmann (daschuer)]

I am not sure if you know already:
http://www.mixxx.org/wiki/doku.php/bugfix_workflow

For this bug you need a new ControlObject e.g. [Recording], duration in seconds.
This can be instantiated somewhere here: https://github.com/mixxxdj/mixxx/blob/8f70bdcb277ed67e6bc53993c1bc97e8c160e141/src/recording/recordingmanager.cpp#L25
(don't be confused by ControlObjectThread below that line. It is legacy code and is not required here any-more)

In a first version you can update your new CO in RecordingManager::slotDurationRecorded() by parsing the sting.

Than you may move QString EngineRecord::getRecordedDurationStr() RecordingManager and path a double instead of the formated via the durationRecorded signal.

EngineRecord::m_recordedDuration should become a double.

Hope that helps.

[ronso0 (ronso0)]

@Daniel: my apologies for the long delay.

I dramatically over-estimated my spare time..
I forgot to mention I'm a C/C++/Cwhatever newbie.

Right now I'm getting familiar with Qt-Creator, trying to understand the mechanics of COs, Widgets etc.
I'll be back when I have something to talk about.

Thanks for your help!
Cheers!

[jus (jus)]

In the Recordings view of the library, there is the `´Start recording``button.
If you start a recording, the filename, current file size, and elapsed time is printed next to the recording button.

I understand the features you are proposing kind of exist already.

[ronso0 (ronso0)]

@Jus: Yes, I know, but to see these features requires to change from Crates/Playlists/History view to Recording view, which is inconvenient while recording a session.
My idea was to have just 2 easy-to-use widgets, i.e. <RecDuration> and <RecButton> which could be placed anywhere in the skin.

I'm sorry, this C stuff is way to abstract for me and I can't assist in porting the available features to a widget. Instead I'll rather focus on building a controller-focused skin.

[jus (jus)]

Thanks for the update.

Recording button feature already exists, i did add demo in the Deere skin, see https://github.com/mixxxdj/mixxx/blob/master/res/skins/Deere/tool_bar.xml#L16 <https://github.com/mixxxdj/mixxx/blob/master/res/skins/Deere/tool_bar.xml#L16>.
Just uncomment the bit in the xml and reload the skin.

Hope someone picks up the ``[Recording],duration`` widget, sounds useful.

> On 06.06.2016, at 21:12, Ronny Sandig <email address hidden> wrote:
>
> @Jus: Yes, I know, but to see these features requires to change from Crates/Playlists/History view to Recording view, which is inconvenient while recording a session.
> My idea was to have just 2 easy-to-use widgets, i.e. <RecDuration> and <RecButton> which could be placed anywhere in the skin.
>
> I'm sorry, this C stuff is way to abstract for me and I can't assist in
> porting the available features to a widget. Instead I'll rather focus on
> building a controller-focused skin.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1529908
>
> Title:
> Display duration of mix being recorded so far - Feature request
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1529908/+subscriptions

[ronso0 (ronso0)]

Thanks for pointing there! This visual feedback for Rec status makes me happy already.

[Ishan (puzzlemeso)]

Hi,

I was wondering if this is an entry level bug / wishlist for somebody new. If yes, I would like to work on this and contribute. Can somebody give me starting pointers on how to be on this way?

Thank you,
Ishan

[Daniel Schürmann (daschuer)]

Welcome Ishan, thank you for offering you contributions.

https://bugs.launchpad.net/mixxx/+bug/1529908/comments/3 contains some useful hints.

I have also just updated this side:
http://www.mixxx.org/wiki/doku.php/developer_guide_control

What else do you need?

[ronso0 (ronso0)]

@Ishan are you working on this?
I made a naive try: https://github.com/mixxxdj/mixxx/pull/1220
Any help is appreciated!

[ronso0 (ronso0)]

Added widget in https://github.com/mixxxdj/mixxx/pull/1221 and info to the wiki http://www.mixxx.org/wiki/doku.php/creating_skins#reording_duration

I can imagine to push this two steps further and create a combination of this label and Recording button where label text for different states can be defined. This would allow a compact widget for skins, without having to stack buttons and labels.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8393