If a connection to a streaming server fails, the [Shoutcast],status CO remains in wrong status, potentially displaying a misleading icon

[jus]

Latest 2.0.0-rc1

The following PR adds a status indicator for the live broadcasting feature:
https://github.com/mixxxdj/mixxx/pull/665/files
https://bugs.launchpad.net/mixxx/+bug/1101329/comments/2

If you try to connect to a streaming server and the connection failed, the
[Shoutcast],status
control remains at the ``failure`` status, while it should return to the ``unconnected`` status when clicking away the obligatory modal window.
This can be observed best with the Shade skin, where you always have the ``failure``icon below the clock, after the first unsuccessful attempt to start live broadcasting.

I`d expect the following:
* Connect to the streaming server
* Error occurs -> ``[Shoutcast],status`` changes to ``failure`` and the password/connection hint modal window appears.
* Click away modal window -> ``[Shoutcast],status`` resets to default ``unconnected``

[Daniel Schürmann (daschuer)]

This behaviour is by design. I think it is correct to show the ``failure``icon until you connect successful live broadcasting works as desired. The configuration / connection was proven as wrong / failure. Keeping the failure until proving the opposite seems to be not bad.

IMHO with the proposed behaviour the failure icon is redundant, since the pop up is displayed at the same time anyway.

[jus (jus)]

The attempt to connect was not successful -> We notify the user about the failure (modal + icon), and about the possible reason (modal). User is notified that action has to be taken, and confirms modal box. We are back in the unconnected state. End of interaction.

Why bother with an failure message afterwards, even if its an icon? This would be exclusive to other error notifications in the application.

[RJ Skerry-Ryan (rryan)]

Did this get fixed?
https://github.com/mixxxdj/mixxx/pull/665

[RJ Skerry-Ryan (rryan)]

(in mixxx 2.0)

[RJ Skerry-Ryan (rryan)]

BTW I agree with Jus in post 2 -- for reliability Mixxx should behave like a state machine from a user's mental model perspective.

[RJ Skerry-Ryan (rryan)]

Nevermind -- the bug was filed after the PR was merged :)

[Be (be.ing)]

Does https://github.com/mixxxdj/mixxx/pull/1300 fix this?

[Daniel Schürmann (daschuer)]

We can consider this bug again after it is merged.
The state icon should work as expected, but I do not agree with the original bug as outlined in #1.

[RJ Skerry-Ryan (rryan)]

Is this still an issue? PR #1300 has merged.

[ronso0 (ronso0)]

Fixed by https://github.com/mixxxdj/mixxx/pull/4001
in 2.3

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8345