Translation issues with menu item names and bindings

[Foss-4]

Today I played a little with the Hotcue points 1-4 one can set for each deck.
OS X 10.10.5
Mixxx 1.12.0-beta1 (built 1.12 r5505) has the problem
Mixxx 1.12.0-beta1 (build 1.12 r5442) ok

Deck 1: Cue Point 1-4 Hotkeys:
1: Y(Z when using US-Keyboard)
2: X
3: C
4: V

Deck 2: Cue Point 1-4 Hotkeys:
1: m
2: ,
3: .
4: - (or / for US keyboard)

Makes sense, but the "," Hotkey is in conflict with the settings Hotkey which is "," as well.

Usually on OS X to open the settings of any application the hotkey for that is "cmd + ," and that is still the case in build r4224. But in r5505 the menubar has changed. And with that the shortcut for settings.

Afaik, there are no current nightly builds for OSX so can't test newer builds. But if this is not yet addressed, it would be great to get feedback on this and probably a fix (which should be rather simple).

[Owen Williams (ywwg)]

Fairly recent OSX builds exist: http://downloads.mixxx.org/builds/1.12/release/?C=M;O=D

[Foss-4 (foss-4)]

Persisting with 1.12.0-beta1 (build 1.12 r5545)

[Owen Williams (ywwg)]

this should be an easy thing to fix

[Owen Williams (ywwg)]

for the record, the problem is that preferences is opening with a bare "," and not "cmd+,"

[Foss-4 (foss-4)]

→ NEW FINDINGS: please read ←

This is related to the system language being used. Everything is fine when system language is english. To trigger the issues, temporarily switch to e.g. german (which is where I ran into the problem).

Issues:

1. "," opens settings (means, hotcue hotkey won't work, it's already taken). should be "cmd + ," for settings
2. Settings menu item location
    * english (correct): mixxx > preferences (cmd+,)
    * german (wrong location): options > preferneces
3. About menu item location
    * english (correct): mixxx > about
    * german (wrong location): help > about

It looks like all issuses are related in that the language change causes things to move around and shuffle it up. Hope with this new info, the problem can be tackled.

[Owen Williams (ywwg)]

Likely fix:

https://github.com/sqlitebrowser/sqlitebrowser/issues/200

My guess is the QT magic triggers only on english and it doesn't know the german words we use. This PR uses some XML to give QT a hand.

[Owen Williams (ywwg)]

https://github.com/mixxxdj/mixxx/commit/57c0ee452968ba3941a9cf3ec62eca05dc411c59

[RJ Skerry-Ryan (rryan)]

That looks like a fix for the menu-location thing (Options vs. Application menu) but do we also have a bad translation in German that's changing 'Ctrl-,' in the code to ','?

[Owen Williams (ywwg)]

In the German translation file, "Ctrl+," is translated as "Strg+," -- maybe that's incorrect?

[RJ Skerry-Ryan (rryan)]

I believe Qt supports Strg, but it's based on translations. It's possible this means we're not correctly loading the Qt translations on Mac.

This is the relevant method:
https://github.com/qtproject/qt/blob/4.8/src/gui/kernel/qkeysequence.cpp#L1195

Based on how we use it, it receives:
QKeySequencePrivate::decodeString("Strg+,", QKeySequence::NativeText)

[RJ Skerry-Ryan (rryan)]

Ok, this actually makes sense. We don't bundle Qt translations in our packaging scripts so Qt doesn't know that "Strg" translates to "Ctrl".

We have code that loads qt_*.qm translations from the bundled translations folder -- we just don't have any code to put the qt_*.qm files in there at packaging time.

[Owen Williams (ywwg)]

RJ can you sketch out what needs to be done to include the qt translations? I'm not sure where to start

[Foss-4 (foss-4)]

Hey all, this bug is no longer happening with 2.1.0 r5675). Must be noted, that on osx with that latest master from yesterday, the menubar is not translated (not sure if that is reported as separate bug already) so the fact that all cue hotkeys are now working could be related to localisations not being picked up correctly?

[Foss-4 (foss-4)]

maybe no longer reproducible due to https://bugs.launchpad.net/mixxx/+bug/1550953 ?

[RJ Skerry-Ryan (rryan)]

Thanks for pointing out the menubar issue. I pushed a fix in:
https://github.com/mixxxdj/mixxx/commit/6e565d0d8abdaca2eaa34ce0aa3dde466dcbfb07

However I think some translations are not matching because they've moved source files. On the next Transifex sync / translation compile everything should sync back up.

[Foss-4 (foss-4)]

persisting with latest master 2.1 r5819

[RJ Skerry-Ryan (rryan)]

Should be fixed with:
https://github.com/mixxxdj/mixxx/commit/f942b60cc4e2e1c01654e0267d6cf2aceecc85cf

Foss-4 confirmed on IRC that the fix works.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8213