cover art is not found on windows

[Max Linke]

build 1.12 r5387

Even though I have the right files in the folder and mixxx finds the jpg on linux it doesn't work under windows. It doesn't happen with a lot of the files but a huge amount. Not sure yet what the reason and the difference between the files is.

[Max Linke (max-linke)]

Files with embedded covers are fine. But mixxx fails to load extract covers from the files in a folder. I'm not yet sure why this is. I also don't know if I have time to build on windows.

[Max Linke (max-linke)]

Ok I got a new build of the 1.12 branch. With my own build everything works. strange.

[Sébastien BLAISOT (sblaisot)]

probably related to lp:1451832

[Max Linke (max-linke)]

This is a little bit strange. According to the test results on the build-server embedded jpg's should work fine.
Our test-data to check embedded cover-art is using jpgs. Can you check if these files are affected for you too?

https://github.com/mixxxdj/mixxx/tree/master/src/test/id3-test-data

If that is the case my next bet would be that we might have a problem with the installer.

[Sébastien BLAISOT (sblaisot)]

This file from your test-data : https://github.com/mixxxdj/mixxx/blob/1.12/src/test/id3-test-data/cover-test.mp3
is an MP3 with PNG embedded cover art.

I don't see any MP3 file with JPEG embedded cover art in the di3-test-data directory.

So it looks like JPEG embedded cover art are never tested at build.

Attached is the library as seen with Mixxx 1.12 beta r5451 64 bits under win seven SP1 64 bits. the jpeg file in folder is never shown, all cover art you see are embedded PNG cover art.

[Sébastien BLAISOT (sblaisot)]

Tests results on the build server can not be trusted because there is a typo in the test jpeg filename in the test suite (coverartcache_test.cpp).
see https://github.com/mixxxdj/mixxx/pull/594

cover-test.jpg versus cover_test.jpg

My bet is that we have a bug in the code, another bug in the test suite, and incomplete test data ;)

[Max Linke (max-linke)]

http://builds.mixxx.org/jenkins/job/1.12-release/architecture=amd64,platform=windows/lastBuild/

The new test results on the buildserver are in. The refactored tests all pass. So it looks like there is no issue in loading the covers in the build. It starts to look more like an issue with the package itself. I've just added the opus testfile to the soundsourceproxy test. Lets see if this fails the windows test

[Sébastien BLAISOT (sblaisot)]

probably the problem is related to http://www.qtcentre.org/threads/43152-Deploying-Qt-Application-on-Windows-Load-JPG-Images-Problem

It seems that que qjpeg4.dll QT ImageFormat plugin is not shipped with Mixxx.

the folder structure should be:
<app folder>
.exe
imageformats/qjpeg4.dll

no problem on linux because QT uses the native libjpeg

[Sébastien BLAISOT (sblaisot)]

ok, I can confirm.

I finally got it working by adding the qjpeg4.dll in Programs\Mixxx\imageformats and reloading metadata from tracks in library.

So there is just a dll missing in the installer (and probably also the Sconstruct script).

I don't know the path of this dll on the build server so I'm affraid I can't help workaround this.

[Sébastien BLAISOT (sblaisot)]

note that we probably have the same problem with gif and tiff as well, we probably need to include all imageformats dll.

[Sébastien BLAISOT (sblaisot)]

Finally, I think i've found how to correct it : https://github.com/mixxxdj/mixxx/pull/596

[Sébastien BLAISOT (sblaisot)]

I just installed freshly compiled mixxx-1.12.0-beta1-1.12-git5465-release-x64.exe (from Mixxx build server) and reanalyzed my libbrary.
I can confirm that the bug is now gone.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7989