MP3: Varying number of channels within a file not supported
Bug #1448224 reported by
Uwe Klotz
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
High
|
Unassigned | ||
Bug Description
SoundSourceMp3 from the new SoundSource API currently rejects MP3 files with a varying number of channels between different MP3 frames.
Proposed Solution:
- Use the maximum number of channels from all MP3 frame headers when loading the file -> 1 or 2 channels
- When decoding an MP3 frame with only 1 channel for a SoundSource with 2 channels duplicate the samples
Up to version 1.12.0 those mono MP3 frames are simply being treated as stereo frames. This approach might work, but is wrong if the MP3 frame header itself is correct.
Revision history for this message
| Uwe Klotz (uklotzde-deactivatedaccount) wrote | #1 |
| Changed in mixxx: | |
| assignee: | nobody → Uwe Klotz (uklotzde) |
Revision history for this message
| Uwe Klotz (uklotzde-deactivatedaccount) wrote | #2 |
| description: | updated |
| Changed in mixxx: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
Revision history for this message
| Uwe Klotz (uklotzde-deactivatedaccount) wrote | #3 |
Revision history for this message
| Uwe Klotz (uklotzde-deactivatedaccount) wrote | #4 |
| Changed in mixxx: | |
| status: | Confirmed → In Progress |
| Changed in mixxx: | |
| status: | In Progress → Fix Committed |
| tags: |
added: soundsource removed: newsoundsourceapi |
| Changed in mixxx: | |
| milestone: | none → 2.1.0 |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #5 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
I will take care of this bug, because it also affects me ;)