bpm_tap only works when no beatgrid is set

[jus]

With latest master on OSX , i can`t get the ``bpm_tap`` control to work, if the track has a beatgrid detected.

The BPM of the track does not change when tapping. Tried to map a keyboard shortcut, assign MIDI, a pushbutton - nothing.
However, i can change the BPM using the tap button in the BPM tab of the Properties editor.

If you right-click > BPM Options > Clear BPM and Beatgrid , tapping works.

Controls are currently in LateNight (Decks) and Shade (Samplers).

Edit:
-----
Ok, now i see you can only tap beatgridded tracks if you have SYNC enabled. Bad for those playing by ear.

Is this intentional?

[jus (jus)]

Still seeing this in latest master, even with latest improvements from https://github.com/mixxxdj/mixxx/pull/450
Confirmed in lp:1530173.

bpm_tap CO does not work with the skins & midi unless SYNC is engaged.
Tapping from within the BPM tab in the track properties editor does work without having SYNC engaged though.

[Be (be.ing)]

Anyone want to take this up? Users ask about it on the forum and IRC fairly often.

[Be (be.ing)]

I think this is a duplicate of Bug 1523286. Is this still an issue in master?

[jus (jus)]

Still present in master as of "Mixxx" "2.1.0-alpha-pre" "(git master r6398; built on: Nov 30 2017)

You can bpm_tap on beadgrided tracks only if channelN is sync_enabled

[Be (be.ing)]

Thank you for testing. We should fix this for 2.1. Anyone want to volunteer to fix it?

[Johan Lasperas (johan-lasperas)]

Made a pull request to fix this : https://github.com/mixxxdj/mixxx/pull/1404

[Be (be.ing)]

https://github.com/mixxxdj/mixxx/pull/1429

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7951