Elide skin tag doesn't work if text is next to an expanding widget

Bug #1434865 reported by Owen Williams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Confirmed
Wishlist
Unassigned

Bug Description

see: https://github.com/mixxxdj/mixxx/pull/506#issuecomment-84412579

If elidable text is next to an expanding widget, even if the text is expanding, it will get prematurely elided and look wrong. My guess is the call to width() is incorrect.

Owen Williams (ywwg)
Changed in mixxx:
assignee: nobody → Daniel Schürmann (daschuer)
importance: Undecided → Low
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Copying the GitHub message:

So the problem is if there's a layout like:
[text wlabel][some other expanding widget]

The width() call is wrong... if the text could fill up available space it doesn't and I get:
[text wlab...][ some other expanding widget]

instead of:
[text wlabel in all its long glory][ some other expanding widget]

I can rework LateNight to not use expanding widgets, but I'm going to put in a TODO and file a bug

Revision history for this message
Daniel Schürmann (daschuer) wrote :

I think the current behavior is correct in the first place.
A elided label has no has no preferred size by default. I just takes the space that is available.
So if it is next to an other expanding widget, the other wins.

Of cause we can implement the other behavior, but it is an other degree of complexity, probably needs additional size hints from the skin.
@Owen: I think you have fixed the issue in LateNight, so there is currently no demand, right?

Changed in mixxx:
importance: Low → Wishlist
status: New → Confirmed
assignee: Daniel Schürmann (daschuer) → nobody
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7913

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.