Add keyboard shortcut to maximize library view

[jus]

Often it is useful to have a bigger library view, and grabbing the mouse/trackpad to press a button not an option.
I propose to use the ``Space`` bar to toggle the max library view.

Deliverables:
* Find naming convention for control. Currently skins use either [Master],show_library or [Library],unshow_big.
   I propose to use [Master],maximize_library
* Add shortcut for control to all *.kbd.cfg
* Update existing tooltip wording

[jus (jus)]

https://github.com/mixxxdj/mixxx/pull/519

[Be (be.ing)]

Many controllers have encoders or buttons for navigating the library. For those that have mappings already, it would be nice if they were updated to take advantage of this new control.

[Raf Van De Meirssche (rafvdm)]

I noticed with the current 1.12-r4518 beta-build, that the space bar maximizes the library view.
So I guess this option is now introduced.

But please note, that I have "shortcut keys DISABLED" and the space bar still does this trick!

Unless I'm wrong, with shortcut keys disabled this should not be functioning.

[Raf Van De Meirssche (rafvdm)]

Also note https://bugs.launchpad.net/mixxx/+bug/1452325 as I think they may be related

[jus (jus)]

@raf
If you deactivate the keyboard shortcuts, the CONFIGURABLE shortcuts for controlling Mixxx features are deactivated.
http://mixxx.org/manual/1.12/chapters/appendix.html#keyboard-mapping-table
http://mixxx.org/wiki/doku.php/mixxxcontrols

The standard application shortcuts in the menu on top of the application window are not deactivated.
http://mixxx.org/manual/1.12/chapters/appendix.html#application-shortcuts

[Raf Van De Meirssche (rafvdm)]

OK, I can live with that. ;-)

Just one more remark, however ...
If this is a standard application shortcut, shouldn't it be marked as such in the drop down list?

[Raf Van De Meirssche (rafvdm)]

"Space" does not show as shortcut key for Maximize Library when running r5431 with Ubuntu 14.04 64-bit.
It does show correctly however when running r5418 with Windows 7 64-bit.

I will install most recent releases as soon as I can, but I am wondering...
It's OK in r5431, but not OK in the less recent r5418?
Are the release numbers not to be trusted across platforms, perhaps?

[Owen Williams (ywwg)]

I've noticed the "Space" indicator doesn't show up when mixxx is in windowed mode, but does at fullscreen. I'm guessing this is an Ubuntu app-menu bug, not a mixxx bug.

[Be (be.ing)]

This control is not doing anything. I tried mapping it to a button press. This is what I see in the debugging output:

Debug [Controller]: "MIDI status 0x90 (ch 1, opcode 0x9), ctrl 0x2C, val 0x7F"
Warning [Controller]: ControlDoublePrivate::getControl returning NULL for ( "[Master]" , "maximize_library" )
Debug [Controller]: "MIDI status 0x90 (ch 1, opcode 0x9), ctrl 0x2C, val 0x00"
Warning [Controller]: ControlDoublePrivate::getControl returning NULL for ( "[Master]" , "maximize_library" )

In the XML mapping file, there is:
            <control>
                <group>[Master]</group>
                <key>maximize_library</key>
                <description>MIDI Learned from 2 messages.</description>
                <status>0x90</status>
                <midino>0x2C</midino>
                <options>
                    <normal/>
                </options>
            </control>

[Be (be.ing)]

Nevermind that, the issue was resolved after "scons -c prefix=~/local install && scons -c && scons prefix=~/local install".

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7892