Improve wording: Sets the key to a compatible key with the other track key, if a key is detected on both.

[jus]

Please help to simplify wording for the following string:
"Sets the key to a compatible key with the other track key, if a key is detected on both."

It`s a trap for translators.

Occurrence:
/src/skin/tooltips.cpp:395

Thanks.

[Daniel Schürmann (daschuer)]

Proposal:
"Sets the pitch to a key that allows a harmonic transition from the other track. It requires a detected key on both decks."

[jus (jus)]

What if we have four, not two decks?

[Daniel Schürmann (daschuer)]

Any suggestion?
IMHO the original track is valid for N-Decks as well because we match always two decks.

Should we ditch the later part?

"Sets the pitch to a key that allows a harmonic transition from the playing track."

[jus (jus)]

> IMHO the original track is valid for N-Decks as well because we match always two decks

If a track is playing in deck 1 and deck 3 and i press the sync key button on the deck 4, which has track loaded, is deck 4 syncing to 1 or 3?

[Daniel Schürmann (daschuer)]

It syncs to the playing deck with the lowest index, in this case deck 1.

[jus (jus)]

With the old tempo SYNC, we had the following rules:
``Syncs to the first deck (in numerical order) that is playing a track and has a BPM. If no deck is playing, syncs to the first deck that has a BPM.```

How are the rules with key sync? Any different prioritization between playing/loaded tracks?

Thanks, and sorry to poke this even more.
Just want to nail this down.

[Daniel Schürmann (daschuer)]

We have kept this rule.

[Daniel Schürmann (daschuer)]

What is the current state of this bug?

[Raf Van De Meirssche (rafvdm)]

To solve the 2-deck/4-deck issue, perhaps change the latter part to something like
"both INVOLVED decks."?

So:
"Sets the pitch to a key that allows a harmonic transition from the other track. It requires a detected key on both involved decks."

But I would drop the "It":
"Sets the pitch to a key that allows a harmonic transition from the other track. Requires a detected key on both involved decks."

[jus (jus)]

https://github.com/mixxxdj/mixxx/commit/c328ed42d66d2e4f96df4ad66a2259d5dd6322e9

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7816