bitcrusher not dry at center position

[Owen Williams]

Quick effects need to be uniform. Currently the bitcrusher is dry at the left position instead of the center, which is incorrect.

[Daniel Schürmann (daschuer)]

Isn't this a duplicate for #1404741?

What should be on the both sides of the filter knob?

[Owen Williams (ywwg)]

This bug is more specific to this one effect, whereas the other bug is asking about design questions that are more long term.

I would be ok with both sides of the bitcrusher being mirror images (dry to wet in either direction). Or, reduce bit depth on one side and reduce sample rate on the other side.

[Owen Williams (ywwg)]

I think we are out of time to design an elegant fix for this. For now I think we should just make a second quick-effect-specific version of the bitcrusher and put a big TODO on it to unify it with the regular bitcrusher.

[Daniel Schürmann (daschuer)]

I would prefer to just add a second set of defaults to every effect, that is used when loading into the quick effect.
There should be fragments of the load and Store code we may use.
I have not ad a look to the code, maybe RJ can help here.

This will also allow to pick filters with different resonance. The current defaults are very decent.

By the way, I think pioneer combines the Bitcusher with the filter to generate two different sides of the Filter knob.
If we decide for a second Bitcrusher, we may implement something like that.

[Owen Williams (ywwg)]

I just want to have one simple bandaid for this one effect for this one release, not add something new to every effect. We do not have time now to design a better solution for the general case.

[Ferran Pujol (ferranpujol)]

+1 to pioneer like bitcrusher+filter

[RJ Skerry-Ryan (rryan)]

I think this is fixed, no?

[Daniel Schürmann (daschuer)]

It is not solved for the quick effect. You can configure the Bitcrusher like that if you change the superknob mapping.
This is only accessible in the effect racks of Shade and Deer

[Pedro Estrela (pestrela)]

still a problem in 2020

[Be (be.ing)]

I don't agree that this is a problem. It wouldn't make sense to have a bipolar bitcrusher knob. Ferran proposed a combination bitcrusher + filter effect above, but that only works well with a low pass filter, not a high pass.

[Pedro Estrela (pestrela)]

my point is that I agree with this sentence:
"Quick effects need to be uniform."
This means that all quickfilters need to be dry at middle position

"You can configure the Bitcrusher like that if you change the superknob mapping."
I think this is the root issue here: quickfilters is, AFAIK, only a shortcut to the effect mapping.
I beleive the new FX feature can decouple this.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7759