cached tracks are not saved

Bug #1397475 reported by Daniel Schürmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
High
RJ Skerry-Ryan

Bug Description

This is a regression since
https://github.com/mixxxdj/mixxx/pull/331

With this patch, cached tracks are not saved, but leaked when shutting down Mixxx, because the destructor are called in a row with shutting down the QT loop. So deleteLater() does not work.

I have tried tonight to fix it with some tricks but I have failed.

I think we must make use of QCoreApplication::aboutToQuit()
http://stackoverflow.com/questions/8165487/how-to-do-cleaning-up-on-exit-in-qt

This sound like a non trivial refactoring job :-/

Changed in mixxx:
milestone: none → 1.12.0
importance: Undecided → High
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

My fix for Bug #1392557 (not yet submitted) gets rid of deleteLater so this should hopefully fix this one as well.

Changed in mixxx:
assignee: nobody → RJ Ryan (rryan)
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Sounds good, thank you.

Revision history for this message
Owen Williams (ywwg) wrote :

probably fixed now?

Owen Williams (ywwg)
Changed in mixxx:
status: New → Fix Committed
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

not fixed

Changed in mixxx:
status: Fix Committed → In Progress
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Should be fixed with this new approach to track caching.

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7693

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.