Numark DJ2Go Cue buttons behave differently

[Raf Van De Meirssche]

Mixxx 1.12.0 (Was also wrong in Mixxx 1.11.0)

The Cue buttons on my little Numark DJ2Go behave differently.
I fixed that with Mixxx 1.11.0 by simply "learning" the control.

First I want to mention that I didn't succeed to fix this in Mixxx 1.12.0 by "learning".
But that is not what this bug report is about.
I will check this out again later, perhaps I missed something simple.

Cueing back to my problem... ;-)

Luckily, you developers have added that wonderful new and more evolved method of which I don't understand the least bit
(for now),
but it helped me to see a difference between the cue actions for Channel 1 and Channel 2.
While for Channel2 there where the Note Off and Note On operation codes, the Note Off was not present for Channel 1.
Setting this right, both Cue buttons behave in the same way and to my taste. :-)

Now, I'm not sure of course that this is THE right solution.
May be I have done more wrong than right... :-(
Can anyone take a glance at this and, if approved, include this in the package?

See the attached screen print.
I have added the first line only.

[Raf Van De Meirssche (rafvdm)]

In the meantime I tend to say that my little modification was the right one.
Can anyone inform me how I can make it generally available?
Where and how do I upload which files for the Numark DJ2Go?

Please be a little (not too much) specific, I never did this before.

[Daniel Schürmann (daschuer)]

Here a rough overview.

* fork Mixxx at github
* clone the repro to you local disk
* create a feature branch
* find your new mapping, e.g. at ~/.mixxx/controller/..
* find the original mapping, at the local source tree res/controllers
* copy your changes to the original file. You may use a diff tool like meld
* commit your changes
* push your feature branch
* create a pull request at github.

Most details are described here: http://www.mixxx.org/wiki/doku.php/bugfix_workflow

Hope that helps.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7654