Album TrackNumber should be stored as int instead of QString

[Max Linke]

The TrackInfoObject is using QStrings to save data like the album track number and year. This can instead be saved as a normal integer. To get a string representation a convenience function like getTrackNumberStr can be used, we are already doing this for
BPM and Bitrate.

[Michael S. (arbeit-u)]

Little Hint: I have seen trucknumbers like "1/16". Will say its "Track 1 from 16". Not good, but i have seen this as tracknumber. Please remember that some stupid things can happens.

[RJ Skerry-Ryan (rryan)]

Track number is a string in many metadata formats so we do this to support
that. Some people use shorthand like "2/3" to note track 2 of CD 3, etc.

On Wed, Nov 12, 2014 at 3:43 PM, Michael S. <email address hidden> wrote:

> Little Hint: I have seen trucknumbers like "1/16". Will say its "Track
> 1 from 16". Not good, but i have seen this as tracknumber. Please
> remember that some stupid things can happens.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1388640
>
> Title:
> Album TrackNumber should be stored as int instead of QString
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1388640/+subscriptions
>

[Avishek Saha (barshan23)]

I have made a patch take a look at it.

[Daniel Schürmann (daschuer)]

Thank you for your work and staring to contribute for Mixxx. :-)

Sorry, for my late objections.
I do not think we should fix this bug that way.
If we read a string from the meta data. we should be able to display and edit it.
If we allow at one point to write back the file meta-data, we must not accidentally overwrite a proper set string value.

Do you experience a bug that is fixed by your patch?
Do we have an issue with the current state? Do reasonable string formats sort correctly?
Lets fix that instead.

By the way: It is best to publish patches as GitHub pull request.
Here you will find some additional hints:
http://www.mixxx.org/wiki/doku.php/bugfix_workflow

Please be aware that the meta data handling has changed between
https://github.com/mixxxdj/mixxx
https://github.com/mixxxdj/mixxx/tree/1.12

[RJ Skerry-Ryan (rryan)]

HI Avishek -- I'm so sorry I didn't make this more clear earlier in my comment #2 in November 2014. We shouldn't convert track number to an integer since it's not an integer (people store complex values in it across their libraries).

The Mixxx library already treats as integer-ish -- when we sort the libary we try to cast to integer for the sort key. So I think this bug is a WontFix.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7623