BPM options submenu double/halve bug

[Jess Boerner]

This is on the latest alpha as of a couple of nights ago. It seems that when right clicking a song in the library and mousing to the "BPM Options" submenu, double BPM and halve BPM do not do their respective actions. Rather, double BPM and halve BPM are switched so when I click double bpm it actually halves and vice versa.

Linux Mint 17
Macbook Air 2011 i7@2.3ghz & 4GB RAM
Intel HD3000

[Jess Boerner (jessboerner)]

At first I thought the bug was produced through time so I killed the current instance of mixxx and restarted, only to find the bug working again. Now later today on the same skin and all (shade_dev) it seems that the buttons work as intended. I'm guessing then that this does happen over time? Memory leak? Who knows, hopefully the update helps.

[Jess Boerner (jessboerner)]

And now an even weirder update. When I selected a bunch of songs (~20) and hit halve BPM, two of the songs doubled while the rest halved.

Not any idea what that means.

[Max Linke (max-linke)]

What version are you using? I can't reproduce this with in the master branch

[Jess Boerner (jessboerner)]

It's not very reproducible, I think it happens based on mixxx being left
open, so it's tough to get it to happen.
On Jul 22, 2014 10:35 AM, "Max Linke" <email address hidden> wrote:

> What version are you using? I can't reproduce this with in the master
> branch
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1341181
>
> Title:
> BPM options submenu double/halve bug
>
> Status in Mixxx:
> New
>
> Bug description:
> This is on the latest alpha as of a couple of nights ago. It seems
> that when right clicking a song in the library and mousing to the "BPM
> Options" submenu, double BPM and halve BPM do not do their respective
> actions. Rather, double BPM and halve BPM are switched so when I click
> double bpm it actually halves and vice versa.
>
> Linux Mint 17
> Macbook Air 2011 i7@2.3ghz & 4GB RAM
> Intel HD3000
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1341181/+subscriptions
>

[RJ Skerry-Ryan (rryan)]

A glance at BeatMap::scale() and it looks buggy to me.

Possible repro steps:
1) Disable constant tempo assumption in preferences
2) Clear track beatgrid (via right-click menu)
3) analyze track
4) hit double/halve BPM

[RJ Skerry-Ryan (rryan)]

A mix of BeatGrid and BeatMap tracks would explain the lack of reproducibility.

I added a fix to BeatMap::scale in https://github.com/mixxxdj/mixxx/commit/87743666d0298c2a0c5d7b187833d511dd8ccfdf so that likely fixed this. Please re-open if you continue to see the error in 1.12.0 alpha builds.

[Jess Boerner (jessboerner)]

I will see what this does, but can you explain the difference between
beatmap and beatgrid? I didn't know there were two types.

Jess
On Nov 22, 2014 11:50 PM, "RJ Ryan" <email address hidden> wrote:

> A mix of BeatGrid and BeatMap tracks would explain the lack of
> reproducibility.
>
> I added a fix to BeatMap::scale in
>
> https://github.com/mixxxdj/mixxx/commit/87743666d0298c2a0c5d7b187833d511dd8ccfdf
> so that likely fixed this. Please re-open if you continue to see the
> error in 1.12.0 alpha builds.
>
> ** Changed in: mixxx
> Assignee: (unassigned) => RJ Ryan (rryan)
>
> ** Changed in: mixxx
> Status: New => Fix Committed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1341181
>
> Title:
> BPM options submenu double/halve bug
>
> Status in Mixxx:
> Fix Committed
>
> Bug description:
> This is on the latest alpha as of a couple of nights ago. It seems
> that when right clicking a song in the library and mousing to the "BPM
> Options" submenu, double BPM and halve BPM do not do their respective
> actions. Rather, double BPM and halve BPM are switched so when I click
> double bpm it actually halves and vice versa.
>
> Linux Mint 17
> Macbook Air 2011 i7@2.3ghz & 4GB RAM
> Intel HD3000
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1341181/+subscriptions
>

[RJ Skerry-Ryan (rryan)]

Thanks Jess!

We don't distinguish the difference in the GUI so that's not surprising :) -- the preference option "assume constant tempo" toggles whether your tracks get a BeatGrid or a BeatMap. The BeatMap is a list of beats while the BeatGrid is a beat (the first beat) and a BPM (which we use to calculate where all the beats are).

BeatGrid is the default -- BeatMap has bugs since it's not commonly used.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7538