Win: MP3 Encoder library load order

[Dennis Wallace]

The new option to use the "real" library name is good (patch on 3/24/14), but it can be made more foolproof.

Currently, the encoding library check can be made to fail if both the lame_enc.dll and libmp3lame.dll files are extracted from the originating archive. By reversing the order of the libraries in the list, we can try for the "proper" one first. This allows the user to not have to rename anything, and also prevents silly user errors.

Yes, I am a silly user that had this happen :)

[Dennis Wallace (mixxx-lp)]

diff --git a/src/encoder/encodermp3.cpp b/src/encoder/encodermp3.cpp
index 95830bf..902763d 100644
--- a/src/encoder/encodermp3.cpp
+++ b/src/encoder/encodermp3.cpp
@@ -79,8 +79,8 @@ EncoderMp3::EncoderMp3(EncoderCallback* pCallback)
 #ifdef __LINUX__
     libnames << "mp3lame";
 #elif __WINDOWS__
- libnames << "lame_enc.dll";
     libnames << "libmp3lame.dll";
+ libnames << "lame_enc.dll";
 #elif __APPLE__
     libnames << "/usr/local/lib/libmp3lame.dylib";
     //Using MacPorts (former DarwinPorts) results in ...

[Dennis Wallace (mixxx-lp)]

Ideally, since we're checking for function existence within the library, the entire validation should probably be within the initial load loop. That way the first VALID library is used, rather than failing on the first INVALID one. Failure would then only happen when no matching libraries are found.

That's a bit more in depth than this patch, but would also solve the issue.

[Dennis Wallace (mixxx-lp)]

Pull request submitted.

[jus (jus)]

Can you please link to the PR so we can close this bug?

[Max Linke (max-linke)]

https://github.com/mixxxdj/mixxx/pull/250

this should be the PR. But it didn't solve the problem

[Owen Williams (ywwg)]

Huh I thought this got fixed along the way -- Max are you saying it still doesn't work right?

[Max Linke (max-linke)]

I have never reproduced the bug and don't have access to a windows machine currently. I can't say if this is fixed or not.

Since the PR didn't get merged my guess would be no.

[RJ Skerry-Ryan (rryan)]

Any updates on this one?

[RJ Skerry-Ryan (rryan)]

Obsolete, since we package LAME with Mixxx in 2.3.0.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7452