Bundle LAME mp3 plugin required for Recording and Streaming

[jus]

"How to obtain and install the mp3 codec, because Recording and Streaming mp3 wont work?"
This is one of the most common support request.

We would do many users and ourselves a favor, if we finally make the whole process user friendly. The current way of downloading from unreliable 3rd-party sites, renaming files and copying to the correct location is error prone, and should be a thing of the past.

I understand that we can not distribute lame binaries, be we can sideload, like in other apps.

Proposal:
If user tries to activate mp3 streaming/recording, do not only display a popup with links too wiki/manual, but allow to download and install the correct codec to the expected location by the click of a single button.

[jus (jus)]

Now that Fraunhofer IIS terminated the MP3 patent-licensing program [1], we can seek to have the mp3 codec legally bundled by default. Fraunhofer recommend [2] to get in touch [3] for official query.

[1] https://www.iis.fraunhofer.de/en/ff/amm/prod/audiocodec/audiocodecs/mp3.html
[2] http://www.audioblog.iis.fraunhofer.com/mp3-software-patents-licenses/
[3] https://www.iis.fraunhofer.de/en/ff/amm/prod/audiocodec/audiocodecs/mp3.html#tabpanel-2

[Daniel Schürmann (daschuer)]

This is how fedora deals with it.
https://fedoramagazine.org/full-mp3-support-coming-soon-to-fedora/

I think we can now just bundle LAME, without a risk to being sued.

I thing we should continue to go with lame, because it is still "maintained" and known to work well.

[jus (jus)]

Nice, changed subject accordingly.

[RJ Skerry-Ryan (rryan)]

https://github.com/mixxxdj/buildserver/issues/32

[RJ Skerry-Ryan (rryan)]

https://github.com/mixxxdj/buildserver/commit/0017c2af086b210f3ddfb0182105c95c06773b62

[RJ Skerry-Ryan (rryan)]

https://github.com/mixxxdj/mixxx/pull/1802

[RJ Skerry-Ryan (rryan)]

Manual updates: https://github.com/mixxxdj/manual/pull/73

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7341