Passthrough overlay image for waveform summary and overview

Bug #1269148 reported by RJ Ryan on 2014-01-14
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mixxx
Low
Unassigned

Bug Description

Maybe once Bug #1180872 is solved the overview and summary will support a "disabled" pixmap so we could draw something on the waveform that says "PASSTHROUGH ENABLED" or something like that.

We could also do this with skin XML to hide the waveform, spinny, and overview and replace it with label widgets or something else (a BIG vu meter?).

RJ Ryan (rryan) on 2014-01-14
Changed in mixxx:
milestone: none → 1.12.0
assignee: nobody → jus (jus)
jus (jus) wrote :

I`m not sure anymore if disabling summary and overview is really the best way to do it. You would have to eject a playing track eventually and whatnot.

E.g. in another soft they just display an text overlay on the affected deck and mute the internal playback. This is pretty nice if you running short on decks (think 2-deck setup) because you can always see whats going on the deck, switch back to internal playback at exact position, and even load tracks to a deck with passthrough enabled.

tags: added: passthrough
Daniel Schürmann (daschuer) wrote :

Nice Idea! +1

RJ Ryan (rryan) wrote :

Ah, I like that too. Currently the EngineBuffer doesn't get processed if passthrough is enabled but if we did that then the deck would still work. So we should add a passthrough overlay pixmap to the summary and overview that is drawn on top when passthrough is enabled.

summary: - Waveform summary and overview should disable when passthrough enabled
+ Passthrough overlay image for waveform summary and overview
Changed in mixxx:
assignee: jus (jus) → nobody
jus (jus) wrote :

Drawing the overlays blocks clicking on the waveform widgets, right?
Any way around this?

RJ Ryan (rryan) wrote :

The implementation I'm imagining would not block mouse input to the widget -- it would just draw the overlay on top (not like the BPM tap button blocking mouse input to the WLabel below it).

Daniel Schürmann (daschuer) wrote :

We currently have non blocking "Overlay" text: "Loading track .."
https://github.com/mixxxdj/mixxx/blob/master/src/widget/woverview.cpp#L330

We can do is similar for "Passthough enabled"

RJ Ryan (rryan) on 2014-03-29
Changed in mixxx:
importance: Undecided → Low
tags: added: polish
Owen Williams (ywwg) on 2014-12-22
Changed in mixxx:
milestone: 1.12.0 → 2.1
Be (be.ing) on 2017-11-11
Changed in mixxx:
status: New → Fix Committed
status: Fix Committed → Confirmed
Be (be.ing) on 2017-11-11
Changed in mixxx:
milestone: 2.1.0 → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers