Key-Lock feature broken in 1.12.0-alpha-pre

[Daniel Sevelt]

uname -a
Linux lighting 3.2.0-34-generic-pae #53-Ubuntu SMP Thu Nov 15 11:11:12 UTC 2012 i686 i686 i386 GNU/Linux
CPU:
Intel(R) Core(TM)2 Duo CPU T7100 @ 1.80GHz
Video:
Unknown
SoundHarware:
Native Instruments AUDIO 4 DJ

Key -Lock button illuminates, however does not function. Key still changes with pitch adjustments
no errors are logged in mixxx.log when the function is turned on and off

[jus (jus)]

Confirmed with latest mixxx-1.12.0-alpha-pre-master-git3567-macintel64

[jus (jus)]

Some kind of weirdness is going on here.

* Reset pitch, then load and start the same track in both decks having keylock deactivated
* While playing, activate keylock on the left deck.
   Notice a phase shifting, even at default pitch
* Now activate keylock on the right deck.
  Instantly, a crackling noise is audible in the output of the deck.

Tested with latest github master on OSX 10.8.5.
Buffer underflow count is @0 , so the latency of my hardware seems not to be an issue here. However, changing the sample rate does change the sound of the crackling noise.

[Daniel Schürmann (daschuer)]

Just tested with current master on Ubuntu 12.4 32bit.

I can confirm a click noise when switching key lock at default pitch and I can confirm the noise on the second deck.
The noise sound like blubber with a 1kHz test tone.
I can reproduce the issue like that:
* Play Deck 2 -> switching key lock works as desired except the click when toggling
* Load Deck 1 (paused) -> blubber noise starts on Deck 2
* Eject Deck 1 -> blubber noise stops.

Mixxx 1.11 is not effected.

[Owen Williams (ywwg)]

this is a Big Deal regression

[Owen Williams (ywwg)]

Should be fixed in trunk. is_scratching was not being initialized to False.

[jus (jus)]

Confirmed working with latest Github master on OSX 10.8.5
Thanks for the quick fix Owen.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7173