hidden tracks are remaining in playlists

[Daniel Schürmann]

Hidden tracks are also "hidden" from play lists. They are still in the database and consumes a number.
This has the advantage, that if you unhidden a track it will appear back in all play lists like before.
But in the hidden status you cannot move or remove the track from the playlist. The number is somehow lost and it looks ugly.

Possible solution: remove hidden tracks from all playlists. (We will loose the unhide redo feature)

Any objections?

[Max Linke (max-linke)]

Hm I'm not sure if redo is a good option for playlists.

hidden tracks are moved around in a playlist unseen. For AutoDJ this might have unsuspected consequences. What if the first Track got hidden a while back. You play a few sets and are just live with autoDJ on and looking for a track. Then you see that it is in the hidden section and you decide to unhide it. Unfortunately that track was also in the AutoDJ playlist and is now the next track. A little bit later that track starts to play instead of the one you intended and you are wondering what is going on. Of course this also applies to other playlists if you don't check them again.

A good solution would be to have tracks removed from playlists when they are hidden and also display a one-time warning that hidden tracks will be removed from playlists to avoid suprises when unhiding them.

[RJ Skerry-Ryan (rryan)]

I would just remove them from the AutoDJ playlist instead of crates and
playlists (and make add-to-autodj on a playlist or crate also only add
non-hidden tracks).

On Mon, Oct 7, 2013 at 2:47 PM, Max Linke <email address hidden>wrote:

> Hm I'm not sure if redo is a good option for playlists.
>
> hidden tracks are moved around in a playlist unseen. For AutoDJ this
> might have unsuspected consequences. What if the first Track got hidden
> a while back. You play a few sets and are just live with autoDJ on and
> looking for a track. Then you see that it is in the hidden section and
> you decide to unhide it. Unfortunately that track was also in the
> AutoDJ playlist and is now the next track. A little bit later that
> track starts to play instead of the one you intended and you are
> wondering what is going on. Of course this also applies to other
> playlists if you don't check them again.
>
> A good solution would be to have tracks removed from playlists when they
> are hidden and also display a one-time warning that hidden tracks will
> be removed from playlists to avoid suprises when unhiding them.
>
> ** Changed in: mixxx
> Status: New => Confirmed
>
> ** Changed in: mixxx
> Importance: Undecided => Medium
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1215066
>
> Title:
> hidden tracks are remaining in playlists
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1215066/+subscriptions
>

[RJ Skerry-Ryan (rryan)]

I think we should remove them from the AutoDJ playlist but otherwise not
remove them from crates, playlists, or history. Instead we should treat
them as if they are not there. When you add a playlist to AutoDJ for
example, we should not add a hidden track from the playlist.

On Wed, Aug 21, 2013 at 2:24 PM, Daniel Schürmann <
<email address hidden>> wrote:

> Public bug reported:
>
> Hidden tracks are also "hidden" from play lists. They are still in the
> database and consumes a number.
> This has the advantage, that if you unhidden a track it will appear back
> in all play lists like before.
> But in the hidden status you cannot move or remove the track from the
> playlist. The number is somehow lost and it looks ugly.
>
> Possible solution: remove hidden tracks from all playlists. (We will
> loose the unhide redo feature)
>
> Any objections?
>
> ** Affects: mixxx
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1215066
>
> Title:
> hidden tracks in playlists
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1215066/+subscriptions
>

[Max Linke (max-linke)]

That will fix auto-Dj but on playlists we will still have a missing number when
we hide a track, which is kind of ugly.

On Mon, 14 Oct 2013 17:38:41 -0000
RJ Ryan <email address hidden> wrote:

> I think we should remove them from the AutoDJ playlist but otherwise not
> remove them from crates, playlists, or history. Instead we should treat
> them as if they are not there. When you add a playlist to AutoDJ for
> example, we should not add a hidden track from the playlist.
>
>
> On Wed, Aug 21, 2013 at 2:24 PM, Daniel Schürmann <
> <email address hidden>> wrote:
>
> > Public bug reported:
> >
> > Hidden tracks are also "hidden" from play lists. They are still in the
> > database and consumes a number.
> > This has the advantage, that if you unhidden a track it will appear back
> > in all play lists like before.
> > But in the hidden status you cannot move or remove the track from the
> > playlist. The number is somehow lost and it looks ugly.
> >
> > Possible solution: remove hidden tracks from all playlists. (We will
> > loose the unhide redo feature)
> >
> > Any objections?
> >
> > ** Affects: mixxx
> > Importance: Undecided
> > Status: New
> >
> > --
> > You received this bug notification because you are a member of Mixxx
> > Development Team, which is subscribed to Mixxx.
> > https://bugs.launchpad.net/bugs/1215066
> >
> > Title:
> > hidden tracks in playlists
> >
> > To manage notifications about this bug go to:
> > https://bugs.launchpad.net/mixxx/+bug/1215066/+subscriptions
> >
>

[Daniel Schürmann (daschuer)]

A alternative solution for AutoDJ is just to show hidden tracks.
This was original proposed in https://github.com/mixxxdj/mixxx/pull/261 Owen.
And seems to be a good band aid fix.

By the way, the only way to get the lost numbers back right now is to:
* Unhide the track
* search all Playlist and AutoDJ
* remove all appreances
* hide the track again

This sound annoying.

But since we have no users complaining about this. It might be a no issue, because you normally do not hid a track that is used in play lists.

So there are two solutions
1. Show hidden tracks in playlists
2. Do not hide tracks that are members of any playlist

I prefer both solution over silently remove the tracks from playlists-

[Owen Williams (ywwg)]

Not adding hidden tracks to AutoDJ was incredibly confusing for me because I was dragging a track from the Browse window and it wouldn't end up in the AutoDJ list. So the current idea is that adding tracks to lists should unhide them.

In the other direction, if someone hides a track, I think that should just remove that track from the playlists in question.

Alternatively, the numbering should be displayed according to what's actually in the widget, not the number in the database. Can't we just use the row number? Maybe I'm unclear on what "number" people are talking about.

[Daniel Schürmann (daschuer)]

> In the other direction, if someone hides a track, I think that should just remove that track from the playlists in question.

This means display hidden tracks in play lists, until the are removed. Sounds good.

I don't like the idea to display the row number, because this introduces a new abstraction (cunfusion) level.
Remember that we can filter and sort playlists.

[Owen Williams (ywwg)]

So during the hide action, we should just be able to create an SQL query that removes hidden track IDs from all playlists, crates, and autoDJ? I guess that's a lot more than "hiding" now :/. Maybe we can detect that a track being hidden is used in a playlist or crate, and pop up a confirmation warning? "Oh shit, I didn't realize this track was being used in this playlist, nevermind."

[Daniel Schürmann (daschuer)]

> So during the hide action, we should just be able to create an SQL query that removes hidden track IDs from all playlists, crates, and autoDJ?

Yes, but not just remove, also renumbering would be required but we have that code already.
But not for the history feature, since it still displays hidden tracks.

[Owen Williams (ywwg)]

OK maybe I'll have time to poke at this tonight. At some point I actually have to start practicing DJing for my upcoming gigs, but I want AutoDJ to work a little better.

[Daniel Schürmann (daschuer)]

We have now a warning Dialog that ask for confirmation to remove the file from the playlist as well.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7151