Auto Reset Gain & Eq after each song

[James Brown]

Request [not bug] Auto Reset Gain & Eq after each song

I've seen this on another DJ application and I would really love this in Mixxx.

The idea being that when gain and eq are adjusted [ at least for me ] it nearly always applies to just one particular song. It's seldom a global setting. And to have to remember to manually reset gain and/or eq after each song is really frustrating.

It would be so much more intuitive to have gain & eq automatically reset to middle values at the end of each song.

[Daniel Schürmann (daschuer)]

Thank you for the bug report!

We should make this a preference option, since controller users will don't like to have their gain and EQ potis out of sync.

[Jonathan Bastnagel (jonthebagel)]

I'll be happy to implement this feature, I'm still setting up my project, however some of the dependencies in the Windows dependency branch aren't included.

Should I file a bug report for this too?

[Daniel Schürmann (daschuer)]

Yes please!
And please assign yourself to the bugs you are working on.

... and thank you very much for contributing to Mixxx :-)

[RJ Skerry-Ryan (rryan)]

Yes, would definitely need to be preference-enabled since many users set the EQ and gain as they prefer for a show and don't touch it. Replaygain should normalize the loudness across tracks so finding one gain setting that works is feasible.

[Rahul Behl (raulbehl)]

Hi Abhnav,

Are you still working on this bug?
If not then I would like to work on it.

[Abhinav Tankha (abhinavtankha)]

Rahul you can go ahead on this.

[Rahul Behl (raulbehl)]

-Added a checkbox to enable Auto Reset Gain & Eq after each song
-If checked, pregain, lowgain, midgain and highgain knob are reset to their center positions

Any suggestions are most welcome.

Thanks,
Rahul

[Daniel Schürmann (daschuer)]

Hi Rahul,

thank you very much for your patch.

Before merge, you need to be come a contributor by signing:
https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ

Please comment here when done.

Some comments:
* Please use ControlObjectSlave in place of ControlObjectThread. ControlObjectThread is deprecated.
* getValueString: please use the overload providing a default.

Would you mind to provide a Pull request at github?
http://neval8.wordpress.com/2013/07/07/en-typical-workflow-with-github-on-shared-project/

Kind regards,

Daniel

[Rahul Behl (raulbehl)]

Hi Daniel

I have signed the Mixxx Contributor Agreement.
I have also opened the pull request replacing ControlObjectThread with ControlObjectSlave.
I could clearly understand what you meant by:
* getValueString: please use the overload providing a default

Link to pull request:

https://github.com/mixxxdj/mixxx/pull/365

[Daniel Schürmann (daschuer)]

getValueString() has a version that allows you to provide a default value. This makes the code a little more easy to read.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7137