Hardcoded 44100Hz in enginefilterblock.cpp

Bug #1208816 reported by xorik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
RJ Skerry-Ryan

Bug Description

File enginefilterblock.cpp has hardoded sample rating values, which incorrect when sampling rate isn't 44100 Hz.

low = new EngineFilterButterworth8(FILTER_LOWPASS, 44100, (int)s_loEqFreq->get());
band = new EngineFilterButterworth8(FILTER_BANDPASS, 44100, (int)s_loEqFreq->get(), (int)s_hiEqFreq->get());
high = new EngineFilterButterworth8(FILTER_HIGHPASS, 44100, (int)s_hiEqFreq->get());

I've made simple test:

1) change filter's frequency to 800-1000Hz http://s21.postimg.org/fy51lk4s7/2013_08_06_131146_689x272_scrot.png
2) kill high and low frequency http://s21.postimg.org/wxe00tfzn/2013_08_06_131156_91x133_scrot.png
3) record some song on different sampling rates and watch spectre: http://s21.postimg.org/8v28325o7/2013_08_06_131254_513x550_scrot.png

You can see wrong result in the 48kHz and 96kHz (higher frequency, than 800-1000), so this need to be fixed.

xorik (xor29a)
description: updated
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: none → 1.12.0
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Confirmed → Fix Committed
assignee: nobody → RJ Ryan (rryan)
Revision history for this message
xorik (xor29a) wrote :
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7129

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.