No track end warning if waveform renderer is set to empty

[Ferran Pujol]

If waveform renderer is set to empty, then the track end warning does not work in the waveform overview.

Not sure if it's a bug or an intended behaviour.

[Daniel Schürmann (daschuer)]

Yes, This is a bug!

I would be happy if you can adopt it according to my hints from mixxx-devel.
Thank you!

[jus (jus)]

I think the end of track warning does not belong to the main waveform at all, it is pretty redundant there.

Currently we display
  a) A blinking gradient on the background of the main waveform
  b) a static rectangle on the background of the waveform overview.

 The end of track warning should go as blinking rectangle exclusively to the waveform overview. Saves performance on the main waveform, while being always prominently visible on the waveform overview.

[ronso0 (ronso0)]

I agree, there should be a blinking rectangle in the overview. Now, that we have 3 skins where the scrolling waveforms can be hidden it's easy to miss the warning. It would also help a lot in minimal decks with max. library' https://github.com/mixxxdj/mixxx/pull/1933 which is almost finished.

To get the most attention for the end warning it should be stacked on top of the dimmed (played) part of the overview
https://bugs.launchpad.net/mixxx/+bug/1792797

[Daniel Schürmann (daschuer)]

https://github.com/mixxxdj/mixxx/pull/1963

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7114