right click "Add to Playlist"+"Add to Crate" items for tracks should have "new" as option

Bug #1179097 reported by RAWRR
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
vedant agarwala

Bug Description

I know that you could just create a new playlist or crate beforehand and then add selected tracks to it. However, it would be smoother and faster for it to also be connected to right click options for selected tracks, especially since other playlist and crate functions are present there too.

RAWRR (rawrr)
summary: - "right click "add to playlist" item should have "new" as option
+ right click "add to playlist" item should have "new" as option
RAWRR (rawrr)
summary: - right click "add to playlist" item should have "new" as option
+ right click "add to playlist" item for tracks should have "new" as
+ option
summary: - right click "add to playlist" item for tracks should have "new" as
- option
+ right click "Add to Playlist"+"Add to Crate" items for tracks should
+ have "new" as option
description: updated
tags: added: crate crates playlists
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Wishlist
Max Linke (max-linke)
tags: added: easy
RAWRR (rawrr)
description: updated
vedant agarwala (vedu)
Changed in mixxx:
assignee: nobody → vedant agarwala (vedant-kota)
Revision history for this message
vedant agarwala (vedu) wrote :

Attached patch fixes the bug. It Builds and runs as expected.

However, there was a lot of code duplication between the 2 (playlist and crate). Also, I mainly copied code from the BasePlaylistFeature and CrateFeature. I tried to avoid more code duplication by inheritance or using "friend" but the problem was that I would be creating a new object. There was no way of accessing the existing the objects of the said classes. Any ideas on this?
Or it will be a major task?
OR, is it best the way it is. Because using templates, inheritance, free form functions, or friend functions/classes will increase coupling? I agree that due to the decoupled nature of mixxx I only had to change one class to add both the features.

Revision history for this message
RAWRR (rawrr) wrote :

Well, it works at least. Awesome job getting the patch in! Sorry to take this long to congratulate you *9_9*

Thanks so much fixing my bug!!

Revision history for this message
Daniel Schürmann (daschuer) wrote :

@Vedant, are you still working on this patch? Or is it ready for review?
Can you remove the QtCreator project files? Does it merge cleanly?

@RAWRR, do you have a public GitHub branch which includes this patch. If yes, it would be helpful to issue a merge request against current mixxxdj/master branch. Thank you.

Revision history for this message
RAWRR (rawrr) wrote :

Ixnay on that, I checked in haste and under lack of sleep. I mistook the normal tree view right click feature for it 9_9

Sorry.

jus (jus)
Changed in mixxx:
status: Confirmed → In Progress
Revision history for this message
jus (jus) wrote :
Changed in mixxx:
milestone: none → 1.12.0
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7025

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.