right click "Add to Playlist"+"Add to Crate" items for tracks should have "new" as option
Bug #1179097 reported by
RAWRR
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Wishlist
|
vedant agarwala |
Bug Description
I know that you could just create a new playlist or crate beforehand and then add selected tracks to it. However, it would be smoother and faster for it to also be connected to right click options for selected tracks, especially since other playlist and crate functions are present there too.
summary: |
- "right click "add to playlist" item should have "new" as option + right click "add to playlist" item should have "new" as option |
summary: |
- right click "add to playlist" item should have "new" as option + right click "add to playlist" item for tracks should have "new" as + option |
summary: |
- right click "add to playlist" item for tracks should have "new" as - option + right click "Add to Playlist"+"Add to Crate" items for tracks should + have "new" as option |
description: | updated |
tags: | added: crate crates playlists |
Changed in mixxx: | |
status: | New → Confirmed |
importance: | Undecided → Wishlist |
tags: | added: easy |
description: | updated |
Changed in mixxx: | |
assignee: | nobody → vedant agarwala (vedant-kota) |
Changed in mixxx: | |
status: | Confirmed → In Progress |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Attached patch fixes the bug. It Builds and runs as expected.
However, there was a lot of code duplication between the 2 (playlist and crate). Also, I mainly copied code from the BasePlaylistFeature and CrateFeature. I tried to avoid more code duplication by inheritance or using "friend" but the problem was that I would be creating a new object. There was no way of accessing the existing the objects of the said classes. Any ideas on this?
Or it will be a major task?
OR, is it best the way it is. Because using templates, inheritance, free form functions, or friend functions/classes will increase coupling? I agree that due to the decoupled nature of mixxx I only had to change one class to add both the features.