EQ kill buttons do not alter waveform

[Dennis Rohner]

EQ kill buttons do not alter new waveform appearance (should have same effect as EQ slider to zero)

[RJ Skerry-Ryan (rryan)]

The kills only affect Filtered Qt-GL.

[RJ Skerry-Ryan (rryan)]

Sorry, I meant this is only correct in Filtered (Qt-GL).

On Fri, May 10, 2013 at 4:41 PM, RJ Ryan <email address hidden> wrote:

> The kills only affect Filtered Qt-GL.
>
> ** Changed in: mixxx
> Status: New => Confirmed
>
> ** Changed in: mixxx
> Importance: Undecided => Low
>
> ** Changed in: mixxx
> Milestone: None => 1.11.1
>
> ** Tags added: easy
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1178813
>
> Title:
> EQ kill buttons do not alter waveform
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1178813/+subscriptions
>

[Leo Combes (combesl)]

EQ kill buttons do not alter waveform appearance, but this is not applicable in all types of waveform, because not all are affected by the EQ knobs.

Before fix the bug:

WORKS WELL:
- filtered - QT (GL)

DONT WORK (to fix):
- filtered software
- filtered (GL)

NO APPLICABLE (EQ knobs not affect waveform):
- simple - QT (GL)
- simple (GL)
- filtered - experimental (GLSL)
- HSV

I attach a patch to fix these (filtered software and filtered GL) waveforms.

[Daniel Schürmann (daschuer)]

Hi Leo,
thank you very much for your work.
We use double != 0.0 -> true conversion. Not 0.5.
Else your patch looks good!
If you like, you can issue a merge request on GitHub. This will simplify the review process.

Kind regards,
Daniel

[Leo Combes (combesl)]

Thanks Daniel.

I have no idea if it is good.

https://github.com/mixxxdj/mixxx/pull/70

Applied double != 0.0.

[Leo Combes (combesl)]

Attach new patch just in case.

[Daniel Schürmann (daschuer)]

Bug is fixed in commit 1b165e2bde28b92634d40feaeeefd0667a65fc6e
1.12.0-alpha-pre (build master r3545)
Thank you Leo!

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7019