Make duration of end-of-track visualisation user configurable

Bug #1160043 reported by dasy2k1
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
Rahul Behl

Bug Description

The waveform flash that starts 30 seconds before the end of the track is a great feature but is a bit too long for me.. I would love to be able to change this in the settings (under the wavform display)

jus (jus)
summary: - Set duration of end of track red flash (currently fixed at 30sec)
+ Make end-of-track visualisation user configurable
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Wishlist
jus (jus)
summary: - Make end-of-track visualisation user configurable
+ Make duration of end-of-track visualisation user configurable
Changed in mixxx:
assignee: nobody → Ferran Pujol (ferranpujol)
jus (jus)
Changed in mixxx:
assignee: Ferran Pujol (ferranpujol) → nobody
Hasit Mistry (hasitnm)
Changed in mixxx:
assignee: nobody → Hasit Mistry (hasitnm)
Hasit Mistry (hasitnm)
Changed in mixxx:
status: Confirmed → In Progress
Revision history for this message
Rahul Behl (raulbehl) wrote :

Is anyone working on this? I'd like to work on this bug (or wish, rather) as my first contribution to Mixxx. Can I get any help on the same (potential source code to look into) ?

Revision history for this message
jus (jus) wrote :

The bug is not assigned to anyone at the moment.
Click on the "Unassigned" link to assign a bug to yourself
Finally, click on the "Assign Me" link (the little yellow exclamation point)
The bug is now assigned for you to work on it.

The developer documentation helps you getting started, see http://mixxx.org/wiki/doku.php#developer_documentation
Mixxx source is @ https://github.com/mixxxdj/mixxx
The end-of-track renderer is @ https://github.com/mixxxdj/mixxx/blob/master/src/waveform/renderers/waveformrendererendoftrack.cpp
Waveform preferences @ https://github.com/mixxxdj/mixxx/blob/master/src/dlgprefwaveform.cpp

Looking forward to your first contribution.

Changed in mixxx:
assignee: Hasit Mistry (hasitnm) → nobody
status: In Progress → Confirmed
Rahul Behl (raulbehl)
Changed in mixxx:
assignee: nobody → Rahul Behl (raulbehl)
Rahul Behl (raulbehl)
Changed in mixxx:
status: Confirmed → In Progress
Revision history for this message
Rahul Behl (raulbehl) wrote :

Can someone (Jus) please review this pull request:

https://github.com/mixxxdj/mixxx/pull/352

I have added a spin box and a slider (in options->preferences->waveform) to make end of the track flash user configurable. Currently, it ranges from 0 (no flash) to 60 secs before the end of the flash.

Any comments and suggestions to improve the current implementation are most welcome.

Revision history for this message
Rahul Behl (raulbehl) wrote :

I forgot to add this patch too. Please check this too. :)
Cleaned and some changes. Not so major ones though.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: In Progress → Fix Committed
milestone: none → 1.12.0
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6964

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.