Beatlooprolls should do their thing when reloop_exit is called
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Low
|
Owen Williams |
Bug Description
On exit from a beatlooproll, the play position is supposed to jump to where it would have been if the loop had not been activated. Currently though, in order to get this behaviour, you have to specifically enable and disable the bealooproll using beatlooproll_
To get beatlooproll behaviour, you have to do this:
//activate the loop
engine.
//deactivate the loop
engine.
...this is a bit of a pain - first, it's not consistent with beatloops - since beatloop_X_enabled also works for beatlooprolls (which is good), I assumed that reloop_exit would also work for beatlooprolls, and it took me a while and a bit of experimentation to figure out that I had to exit using the activate function. Second, it's a pain in scripts, because you have to keep track of which specific length of beatlooproll is enabled in order to specifically disable that length of beatlooproll using "beatlooproll_
If it's difficult to make reloop_exit work for both, then Mixxx should at least provide a looproll_exit function or something, so you don't have to keep track of the length of the currently active beatlooproll in order to disable it.
One possible solution to this would be to make beatloops and beatlooprolls the same thing until the loop exits (ie: user starts loop, Mixxx tracks the resume position in case the user wants to make this a beatlooproll, and then the user calls either reloop_exit or beatlooproll_exit depending on what behaviour they want.) This might be a better implementation, since the user wouldn't have to make up their mind until they're ready to exit the loop.
description: | updated |
Changed in mixxx: | |
status: | New → Confirmed |
description: | updated |
tags: | added: loop |
tags: |
added: looping removed: loop |
summary: |
- Wishlist: Beatlooprolls should do their thing when reloop_exit is called + Beatlooprolls should do their thing when reloop_exit is called |
Changed in mixxx: | |
importance: | Undecided → Wishlist |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
I think this is a bug not a wishlist :). We should fix this in 1.12.