If Qt is not found or broken, SCons reports that other dependencies are missing.

Bug #1132995 reported by RJ Skerry-Ryan
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Won't Fix
Low
Unassigned

Bug Description

This bites people from time to time and we should fix it. An easy thing to do is just to bail early when we load the Qt4 tool if we can't build a test binary with Qt linked.

Tags: build
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
tags: added: build scons
Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

Seems to me that Qt gets needlessly linked in to dependency checks that have nothing to do with it, like libsndfile. Removing these would go a long way toward resolving this.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Yea, if you look at config.log you can see that every additional dependency check appends to the build configuration. So if you add portaudio, and we check for opus next, -lportaudio is part of that compile line testing for opus.

The Qt support script we use (qt4/qt5.py) blindly appends to the configuration rather than testing for presence of qt libraries -- whereas using conf.CheckLib/CheckHeader (which we do for other libraries) does not append to the environment if the config check fails.

Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

So is that the solution, or at least the start? Change the qt4/5 script to use CheckLib/CheckHeader?

Revision history for this message
RJ Skerry-Ryan (rryan) wrote : Re: [Bug 1132995] Re: If Qt is not found or broken, SCons reports that other dependencies are missing.

Yea -- pretty much -- or move Qt to be last in the dependency checks.

On Wed, Jun 15, 2016 at 1:31 PM, Sean M. Pappalardo <
<email address hidden>> wrote:

> So is that the solution, or at least the start? Change the qt4/5 script
> to use CheckLib/CheckHeader?
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1132995
>
> Title:
> If Qt is not found or broken, SCons reports that other dependencies
> are missing.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1132995/+subscriptions
>

tags: removed: scons
Changed in mixxx:
status: Confirmed → Won't Fix
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6928

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.