Waveform scratch: track is always stopt before mouse speed is adopted

Bug #1117762 reported by Daniel Schürmann on 2013-02-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Medium
Daniel Schürmann

Bug Description

This is due to the PID Controller starts with a rate of zero and the start of scratch has a mouse move of zero.

Changed in mixxx:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Daniel Schürmann (daschuer)
milestone: none → 1.11.0
RJ Skerry-Ryan (rryan) wrote :

Hm, this is intentional since if you click the waveform and don't move it should stop.

Daniel Schürmann (daschuer) wrote :

But It stops before it knows if the mouse moves. It should not stop if the mouse initial moves with waveform speed.

Daniel Schürmann (daschuer) wrote :

The patch from Bug #1086999 solves the problem.

Daniel Schürmann (daschuer) wrote :

I will prepare a separate patch for this issue.

Daniel Schürmann (daschuer) wrote :

The patch from Bug #1086999 solves the problem again!

Daniel Schürmann (daschuer) wrote :

This is the reply to Bug #1086999 #26 from Jus:

> * Is the delay intentional that occurs when you hold the waveform? It is
> noticeable and feels a little strange. The higher the latency, the more
> significant the effect, nearly brake-like at high latency. If you touch a vinyl,
> it holds immediately. Thats what i would expect from our mouse scratch too.

With mouse scratch we have the problem, that the mouse updates are processed in non equal times with an undefined delay and we cannot distinguish if the mouse is stopped or the mouse update is delayed.

The mouse issues are handled by a p controller which adds a delay of ~50 ms to the mouse scratch in slatted state.

This is not like the finger on the vinyl as the ideal case would be. Mouse scratching id more like scratching with a ball pen spring :-)

For starting mouse scratch, we have two use cases:
* Stopping the track
* start scratching

Have you tested scratch start? My test was moving the track with a rate of one by mouse.

The patch changes the waveform start on a playing deck with to a settled controller with the current rate.
This way it is possible to change the track rate while scratching without always starting at zero which produces a hearable pause . (The issue of this bug)
The drawback of this approach is break effect you have noticed if you want to stop the track. (Like stopping with a ball pen spring)

I like the patch because it introduces the same behavior for the whole mouse scratch process. But I understand the objections when testing track stopping.

Is stopping the track via waveform scratch a valid use case when DJing? (We have the pause button in any case). For me, starting scratching is the main use case which should work fine first.

If you not agree, we may not fix this bug, or delay the scratch start and stop until we can decide if the mouse is stopped or moving (after ~50 ms)

Daniel Schürmann (daschuer) wrote :

the patch from Bug #1117806 includes a solution for this bug with
stop detection.
@Jus, hope you will like it now ;-)

Daniel Schürmann (daschuer) wrote :

Committed to lp:mixxx 1.11 revision 3776.

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan) on 2013-05-09
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers