no progress bar when waveform already analyzed

Bug #1100478 reported by Daniel Schürmann on 2013-01-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Low
Daniel Schürmann

Bug Description

If the analyzer runs after removing the beatgrid the waveform overview is already rendered. So there is no visible progress bar.

Changed in mixxx:
status: New → Confirmed
assignee: nobody → Daniel Schürmann (daschuer)
milestone: none → 1.11.0
Changed in mixxx:
status: Confirmed → In Progress
jus (jus) on 2013-01-18
tags: added: waveform
Changed in mixxx:
importance: Undecided → Low
RJ Skerry-Ryan (rryan) wrote :

Patch looks good except the change to analyserqueue.cpp looks unrelated.

Daniel Schürmann (daschuer) wrote :

I have set
#define FINALISE_PERCENT 100 // in 0.1%
to have a visible progress bar during the finalize period.
We had previously rejected a solution where the waveform was shown slower than the actual waveform analysis.
But now this effects the new progress bar instead and should be save.

Patch committed to lp:mixxx/1.11 #3702

Changed in mixxx:
status: In Progress → Fix Committed
jus (jus) wrote :

Not sure if it is related, but there is a interesting effect with Sample decks >4.
Tested with latest lp:mixxx/1.11 r3708

* Select a skin with more than 4 Sample decks like DeereSamplegrid1280x800-WXGA or Deere1920x1080-FullHD
* Load a track to Sample deck 5 or greater

The waveform does not show up, instead "Ready to play, analyzing" is displayed.
If you load the same track also in Sample Deck 4, the waveform/analyze process is displayed for all sample decks were the same track is loaded.

RJ Skerry-Ryan (rryan) on 2013-05-09
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers