Allow setting position marker color from skin

Bug #1099182 reported by Daniel Schürmann on 2013-01-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Wishlist
Daniel Schürmann

Bug Description

Currently it is painted in axis color on the waveform and in maker color on the overview.

Changed in mixxx:
status: New → In Progress
assignee: nobody → Daniel Schürmann (daschuer)
Daniel Schürmann (daschuer) wrote :

The attached patch introduces the optional
<PlayPosColor></PlayPosColor>
fallback is AxisColor.

The patch fixes also the wrong BgColor in all Shade skins.

It fixes the color scheme support for AxisColor. Because of this the Axis is now hard to see in Outline Classic. So we need to tweak the Axis color for Outline.

This batch is the base for some other 1.11.0 fixes, so it is itself 1.11.0

Changed in mixxx:
milestone: none → 1.11.0
jus (jus) on 2013-01-18
Changed in mixxx:
importance: Undecided → Wishlist
jus (jus) wrote :

Is it really necessary to introduce the <PlayPosColor> key?
For the waveform overview we use <MarkerColor> to set the playposition color, so can't we just make <MarkerColor> to work on the regular waveforms too ? Currently all skins use the <MarkerColor> key in the waveform part of the skin.xml, but i can't see it does anything.

jus (jus) wrote :

After trying your patch from lp:1094791, i just realized that you introduced <PlayPosColor> for both the waveform and waveform overview. This makes my previous comment somehow superfluous.

Is <MarkerColor> now obsolete with your patches and can be deleted from skin.xml?

jus (jus) wrote :

As for the BgColor in the Shade skins: This is by purpose iirc is the background transparent if no <BgColor> & <BgPixmap> are present

RJ Skerry-Ryan (rryan) wrote :

1) <MarkerColor> is used as a fallback by all the WaveformRenderMark (hotcues) and WaveformRenderMarkRange (loops) on the waveform and overview. So if no <Color> is provided for a mark or markrange then it falls back on <MarkerColor> of the parent.

I think we should get rid of MarkerColor everywhere and make WaveformMark and WavformMarkRange both use <AxesColor> as the fallback if no <Color> is present.

2) m_qMarkerColor can now be removed from WOverview I believe.

3) Not sure I see the difference between AxesColor and PlayPosColor?

Daniel Schürmann (daschuer) wrote :

Thank you for review!

1) is tracked in Bug #1107163

2) Yes, this code should be removed.

3) AxesColor is the color of the static horizontal line and PlayPosColor is the color of the static vertical line on the Waveform and the cursor in the WOverview.

Daniel Schürmann (daschuer) wrote :

committed to lp:mixxx/1.11 revision 3681

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan) on 2013-05-09
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers