Background graphic for waveform overview does not fit in various skins

Bug #1099180 reported by Daniel Schürmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
jus

Bug Description

Tested with lp:mixxx/1.11 #3672

Tags: skin

Related branches

jus (jus)
Changed in mixxx:
milestone: none → 1.11.0
status: New → Incomplete
status: Incomplete → Confirmed
importance: Undecided → Low
assignee: nobody → jus (jus)
Revision history for this message
jus (jus) wrote :

Why is it important to have the background image exactly in the dimensions of the waveform widget? What if the spinning vinyl widget is displayed and the waveform widget shrink?

tags: added: skin
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Due to the changes from Bug #1094791 I have removed
painter.setRenderHint(QPainter::Antialiasing);
Now the vertical bars on the background image have a different width due to the resize.

Revision history for this message
jus (jus) wrote :

Thanks for the info.
I`m tempted to remove the fixed vertical bars in all skins, they are odd anyway.
Added them back then to the skins as kinda visual guide for relative positioning within a track, but better real world ideas are in lp:746456.

Changed in mixxx:
status: Confirmed → In Progress
Revision history for this message
jus (jus) wrote :

Removed the separate background graphic for waveform overviews in all affected skin.xml in http://bazaar.launchpad.net/~mixxxdevelopers/mixxx/release-1.11.x/revision/3752
The issue with the stretched vertical bars on the background image is no more because the waveform background is transparent if no <BgColor> & <BgPixmap> is present. Now you see directly the skins background image.

summary: - style_bg_woverview does not fit in Deere 1366
+ Background graphic for waveform overview does not fit in various skins
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6843

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.