Buttons in AutoDJ and Analyse should be styled

Bug #1094928 reported by Max Linke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
jus

Bug Description

I found that the buttons could be styled with a stylesheet. I would like if these buttons are styled in new skins because these buttons look a bit strange right now because they don't follow the ususal styling of the skin.

Tags: skin
Revision history for this message
Max Linke (max-linke) wrote :
Revision history for this message
Max Linke (max-linke) wrote :
Revision history for this message
jus (jus) wrote :

Qt provides standard widgets that look like those described in the interface guidelines for the respective operating system. We use some of them, e.g. (radio)button, tableheader, scrollbar. Your patch may work on Win, but makes the button an alien on other OS. If we choose to customize the look of standard widgets, we must do so for all elements. The Spartan skin in the forums is an example. The potential problem with this approach is, that it may not work with skins that use the color scheme architecture (untested).

tags: added: skin
Revision history for this message
Max Linke (max-linke) wrote :

I've tried it on Linux. From my experience it will look the same on any OS if the buttons are styled in the skin.xml, the new preview button is a example for this. The Spartan skins does what I'd like to see with the other skins as well, because unstyled they look a bit out of place for me.

I also tested the patch with the outline skin without problems.

jus (jus)
Changed in mixxx:
assignee: nobody → jus (jus)
status: Confirmed → In Progress
milestone: none → 1.12.0
Revision history for this message
jus (jus) wrote :

Fixed in Deere skin

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6822

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.