Improve visibility of current pos in the waveform display

Bug #1094791 reported by Daniel Schürmann on 2012-12-31
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Daniel Schürmann

Bug Description

This was requested by jus to have a shadow like in waveform overview.

Changed in mixxx:
assignee: nobody → Daniel Schürmann (daschuer)
status: New → In Progress
importance: Undecided → Low
Daniel Schürmann (daschuer) wrote :

The attached patch does it like requested.
We may have to tweak it or the beat markers Bug #1088232 for a harmonic view.

jus (jus) wrote :

After tying the patch, i can't say there is any noticeable difference.
What about removing the opacity and displaying a straight 1-2px line in axescolor with a fixed 1px black outline? It is about maximum contrast after all, and with the outline you'll get this even on near-black background/multicolored waveform.

jus (jus) wrote :

Oops, used a wrong term in #2 which could lead to misunderstandings. Instead "removing the opacity" it is meant to "remove the transparency" aka set Opacity=1.0.

We should also set the Opacity=1.0 for the current position marker in the waveform overview, the current semi-transparent marker just looks bad especially with color scheme skins..

Changed in mixxx:
milestone: none → 1.11.0
Daniel Schürmann (daschuer) wrote :

The attached patch improves the visibility in both waveforms.
The patch from Bug #1099182 is required for this one.
There might be a color tweak required with <PlayPosColor></PlayPosColor> for some skins.

jus (jus) wrote :

Looks good now. Thanks.
Going to add the <PlayPosColor> tweaks to the skins.

Daniel Schürmann (daschuer) wrote :

Committed to lp:mixxx/1.11 revision 3682

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan) on 2013-05-09
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers