allow color schemes for WidgetGroup backgrounds

Bug #1094785 reported by Daniel Schürmann on 2012-12-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Low
Daniel Schürmann

Bug Description

This is an aspect discussed in https://bugs.launchpad.net/mixxx/+bug/1071500 from #3 ff.

The current workaround fro outline skins is to use a dummy button.

Changed in mixxx:
assignee: nobody → Daniel Schürmann (daschuer)
status: New → In Progress
importance: Undecided → Low
summary: - allow color shemes for WidgetGroup backgrunds
+ allow color schemes for WidgetGroup backgrunds
summary: - allow color schemes for WidgetGroup backgrunds
+ allow color schemes for WidgetGroup backgrounds
Daniel Schürmann (daschuer) wrote :

The attached patch introduces a new node <BackPath> for setting an color scheme able image to a WidgetGroup.

Note: The style sheet is painted on top of the new background set by the new node.

jus (jus) on 2012-12-31
tags: added: sk
Changed in mixxx:
milestone: none → 1.11.0
tags: added: skin
removed: sk
RJ Skerry-Ryan (rryan) wrote :

Patch looks good though I seem to remember when I created WidgetGroups that it was important to add the widgets to the layout before setting the layout on the WidgetGroup. If you haven't seen any problems with the current skins from doing it this way then it was probably some quirk of my setup.

Minor nit: I would do setObjectName in the constructor instead of setup.

Daniel Schürmann (daschuer) wrote :

commited to lp:mixxx/1.11 #3663.

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan) on 2013-05-09
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers