prioritize tracks with stored analysis in analysis queue

Bug #1087995 reported by Daniel Schürmann on 2012-12-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Low
Daniel Schürmann

Bug Description

Currently, If you load a already analysed track to a deck, the waveform is displayed after a possible running analysis on an other track is finished.

I will prepare a patch which instantly loads the analysis data for already processed tracks.

Changed in mixxx:
status: New → In Progress
assignee: nobody → Daniel Schürmann (daschuer)
Daniel Schürmann (daschuer) wrote :

the attached patch works like described. It it includes the changes from Bug #1088071.
It was created against lp:mixxx/1.11 #3590

Hm, my only worry is that we throw away partially completed analysis of a
track whenever you load another track that has pre-calculated analyses.

On Mon, Dec 10, 2012 at 3:10 PM, Daniel Schürmann <
<email address hidden>> wrote:

> the attached patch works like described. It it includes the changes from
> Bug #1088071.
> It was created against lp:mixxx/1.11 #3590
>
> ** Patch added: "prioritize_analysis.patch"
>
> https://bugs.launchpad.net/mixxx/+bug/1087995/+attachment/3456530/+files/prioritize_analysis.patch
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1087995
>
> Title:
> prioritize tracks with stored analysis in analysis queue
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1087995/+subscriptions
>

Daniel Schürmann (daschuer) wrote :

Hi RJ,

Thank you fro review!

> Hm, my only worry is that we throw away partially completed analysis of a
> track whenever you load another track that has pre-calculated analyses.

In one of my first version this was the case but now I have made it const
virtual bool loadStored(TrackPointer tio) const = 0;
so a running analysis is not disturbed.

Commit to lp:mixxx/1.11?

RJ Skerry-Ryan (rryan) on 2012-12-13
Changed in mixxx:
milestone: none → 1.11.0
importance: Undecided → Low
RJ Skerry-Ryan (rryan) wrote :

Thanks -- I didn't read closely enough.

In most of the analyzers from initialize() you call loadStored() and return false if the track initialized. I don't see this in AnalyserBeats. Is there a particular reason for that?

Otherwise looks good to commit. The patch also includes the fix from Bug #1088071, right?

RJ Skerry-Ryan (rryan) wrote :

I plan to tag beta2 tomorrow and would definitely like this to be included so we can get it tested. Thanks!

Daniel Schürmann (daschuer) wrote :

Committed to lp:mixxx/1.11 #3626.

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan) on 2013-05-09
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers