visual sample rate does not match on tracks with different sample rate

Bug #1087425 reported by Daniel Schürmann on 2012-12-06
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Low
Daniel Schürmann
1.11
Low
Daniel Schürmann

Bug Description

The waveform analyser tries to find the best visual sample rate around 441 Hz in Waveform::computeBestVisualSampleRate.

Unfortunately it has not the same results on tracks with 48000 and 44100 Hz are different, 444,4 / 441
The result is a visual beat unmaching when synced from 4 pixels each side at LateNight1366x768-WXGA.
The result can be worse with other sample rates.

Not a big deal, but fixing is a big deal.

This will strictly speaking introduce a new waveform version.
This will force all 1.11 beta tester to re analyse their tracks.

We may also change it without notice, so the error will persist for all beta attester.
Only useres with 48000 Hz files are effected.
....

Or we leave it as it is.

The same problem is the case for Bug #1086965

RJ Skerry-Ryan (rryan) wrote :

That's what you get for using beta software. :) People will have to recalculate their waveforms.

I say we fix it the right way and now that we have proper versioning on our waveform calculation we can easily and safely do this upgrade.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
Changed in mixxx:
status: Confirmed → In Progress
assignee: nobody → Daniel Schürmann (daschuer)
Daniel Schürmann (daschuer) wrote :

Attached you will find a patch fixing this issue and Bug #1086965.

I have introduced 4.0 Waveforms. 3.0 Analysis are removed from database while 2.0 Analysis are keep to use older Mixxx versions.

jus (jus) on 2012-12-31
tags: added: waveform
RJ Skerry-Ryan (rryan) wrote :

Sorry for the epic long review here. It took me a long time to break this into chunks and verify it all. Looks good!

Daniel Schürmann (daschuer) wrote :

Committed to lp:mixxx/1.11 revision 3700

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan) on 2013-05-09
Changed in mixxx:
status: Fix Committed → Won't Fix
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers